Re: [PATCH] completion: verify-tag is not plumbing

[Junio C Hamano <gitster@pobox.com>]

John Keeping <john@keeping.me.uk> writes:

> I can accept that argument about verify-commit and verify-tag, but
> listing verify-tag as plumbing is incorrect according to
> command-list.txt (and thus git(1)).  If we're going to classify
> commands, shouldn't we be consistent in how we do so?

These are not meant to be "classifications", but "justifications".
When somebody asks "why isn't this command tab-completed?", you can
find the explanation e.g. "because it is rarely used".

A command being 'plumbing' does not have to make it automatically
ineligible from getting tab-completed.  For some small tasks,
running a plumbing command may be the easiest way to achieve them in
the interactive session, and it helps to have tab-completion for
such a plumbing command (e.g. "git apply" is completed, IIRC).

Also often the line between plumbing and Porcelain is somewhat
blurry.  I'd consider ancillaryX categories in command-list.txt a
cop-out myself.

In this particular case, saying "better use 'tag --verify'" there
instead of "plumbing" may be more helpful for those who are reading
this script.

>> > Signed-off-by: John Keeping <john@keeping.me.uk>
>> > ---
>> >  contrib/completion/git-completion.bash | 1 -
>> >  1 file changed, 1 deletion(-)
>> >
>> > diff --git a/contrib/completion/git-completion.bash
>> > b/contrib/completion/git-completion.bash
>> > index 51f5223..250788a 100644
>> > --- a/contrib/completion/git-completion.bash
>> > +++ b/contrib/completion/git-completion.bash
>> > @@ -728,7 +728,6 @@ __git_list_porcelain_commands ()
>> >  		write-tree)       : plumbing;;
>> >  		var)              : infrequent;;
>> >  		verify-pack)      : infrequent;;
>> > -		verify-tag)       : plumbing;;
>> >  		*) echo $i;;
>> >  		esac
>> >  	done
>> > --
>> > 2.7.0