All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: "GIT Mailing-list" <git@vger.kernel.org>,
	"Ramsay Jones" <ramsay@ramsayjones.plus.com>,
	"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH v2] sparse: allow '{ 0 }' to be used without warnings
Date: Sun, 24 May 2020 09:17:29 -0700	[thread overview]
Message-ID: <xmqqa71xqpd2.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200522002502.9010-1-luc.vanoostenryck@gmail.com> (Luc Van Oostenryck's message of "Fri, 22 May 2020 02:25:02 +0200")

Luc Van Oostenryck <luc.vanoostenryck@gmail.com> writes:

> Note: The option have just been added to Sparse. So, to benefit
>       now from this patch it's needed to use the latest Sparse
>       source from kernel.org. The option will simply be ignored
>       by older versions of Sparse.

The last sentence in this paragraph is very very much appreciated
;-)

>
> [1] https://lore.kernel.org/r/e6796c60-a870-e761-3b07-b680f934c537@ramsayjones.plus.com
> [2] https://lore.kernel.org/r/xmqqd07xem9l.fsf@gitster.c.googlers.com
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
>
> Change since v1:
> * adapt the commit message to:
>   - fix a typo
>   - give a reference to the Spatch patch
>   - add a note telling the latest Sparse source is needed to
>     benefit from the patch but older versions won't complain.
>
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 3d3a39fc19..69f065ef8c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1189,7 +1189,7 @@ PTHREAD_CFLAGS =
>  
>  # For the 'sparse' target
>  SPARSE_FLAGS ?=
> -SP_EXTRA_FLAGS =
> +SP_EXTRA_FLAGS = -Wno-universal-initializer
>  
>  # For the 'coccicheck' target; setting SPATCH_BATCH_SIZE higher will
>  # usually result in less CPU usage at the cost of higher peak memory.

  reply	other threads:[~2020-05-24 16:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  0:25 [PATCH v2] sparse: allow '{ 0 }' to be used without warnings Luc Van Oostenryck
2020-05-24 16:17 ` Junio C Hamano [this message]
2020-05-30 16:24   ` Luc Van Oostenryck
2020-05-31 16:48     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa71xqpd2.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.