All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	newren@gmail.com, Git Mailing List <git@vger.kernel.org>
Subject: Re: t6044 broken on pu
Date: Sat, 07 May 2016 19:21:32 -0700	[thread overview]
Message-ID: <xmqqa8k11e8j.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <d1fcc54b-ddd7-b03b-79fa-2112a3f43141@web.de> ("Torsten =?utf-8?Q?B=C3=B6gershausen=22's?= message of "Sat, 7 May 2016 18:18:30 +0200")

Torsten Bögershausen <tboegi@web.de> writes:

> That's true, but the test passes anyway.

You can also remove the body of the test and replace it with "true"
and say "the test passes anyway".  Changing the test to use a file
with only one line is irresponsible, if you do not know the nature
of expected future bug that requires 10 lines to be there to
manifest that the test wants to try.

test_seq was invented exactly for the purpose of accomodating
platforms that lack seq, so using it would probably be the best
first step.  Updating implementation of test_seq to avoid $PERL
would be a separate step, if desired (I personally do not think
that is worth it).

  reply	other threads:[~2016-05-08  2:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-07 12:00 t6044 broken on pu Torsten Bögershausen
2016-05-07 12:19 ` Andreas Schwab
2016-05-07 13:15   ` Ramsay Jones
2016-05-07 13:43     ` Ramsay Jones
2016-05-07 16:18   ` Torsten Bögershausen
2016-05-08  2:21     ` Junio C Hamano [this message]
2016-05-08  6:54       ` Torsten Bögershausen
2016-05-08 18:20         ` Junio C Hamano
2016-05-09  4:43           ` Torsten Bögershausen
2016-05-09 18:22             ` Junio C Hamano
2016-05-09  6:30           ` demerphq
2016-05-09  8:33             ` Jeff King
2016-05-09 16:02               ` Eric Sunshine
2016-05-09 16:12                 ` Jeff King
2016-05-09 18:26                   ` Junio C Hamano
2016-05-09 18:36                     ` Junio C Hamano
2016-05-09 20:10                       ` Eric Sunshine
2016-05-09 21:08                       ` Junio C Hamano
2016-05-09 21:27                         ` Eric Sunshine
2016-05-10  2:41                       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa8k11e8j.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=schwab@linux-m68k.org \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.