All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Fernando Ramos <greenfoo@u92.eu>,
	git@vger.kernel.org, davvid@gmail.com, sunshine@sunshineco.com,
	seth@eseth.com, levraiphilippeblain@gmail.com,
	rogi@skylittlesystem.org
Subject: Re: [PATCH v6 3/3] vimdiff: add tool documentation
Date: Sun, 27 Mar 2022 22:43:21 -0700	[thread overview]
Message-ID: <xmqqbkxq639i.fsf@gitster.g> (raw)
In-Reply-To: <2d1b3c6d-4345-8b7d-b8b8-4baf1edd91f0@gmail.com> (Bagas Sanjaya's message of "Mon, 28 Mar 2022 11:48:08 +0700")

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> On 27/03/22 18.23, Fernando Ramos wrote:
>> +When using these variants, in order to specify a custom layout you will have to
>> +set configuration variables `mergetool.gvimdiff.layout` and
>> +`mergetool.nvimdiff.layout` instead of `mergetool.vimdiff.layout`
>> +
>
> What about this wording?
>
> "These variants also have corresponding layout configuration named
>  `mergetool.gvimdiff.layout` and `mergetool.nvimdiff.layout`, respectively."

Hmph.  The wording aside, is it a good design that you have to set
gvimdiff.layout if you use gvim and your setting to vimdiff.layout
has no effect when you are using nvim or gvim?

What is the reason why a user may want to specify them separately?

 * I want to use this layout when using plain vim but gvim is so
   different that I want to use a different one from usability's
   point of view.

 * The layout I want to use with plain vim, when fed to gvim or
   nvim, would totally make them misbehave.  I cannot reuse the same
   layout even if I wanted to.

 * Depending on the kind of conflict I deal with, I want to use
   different layouts, but there is no easy mechanism to choose
   between multiple values I give to mergetool.vimdiff.layout, so I
   use one layout for vimdiff and another for gvimdiff, and
   depending on the layout I want to use, I switch between vimdiff
   and gvimdiff.

 * Something else?

If on the other hand, a user may want to stick to a single layout no
matter which variant of vim is used, it may make more sense to just
use a single mergetool.vimdiff.layout across all the different
variants of vim implementations, and possibly, have their own one
override the most generic "vimdiff" one.  E.g. gvimdiff would use
mergetool.gvimdiff.layout if exists, or mergetool.vimdiff.layout
otherwise.

I dunno.

  reply	other threads:[~2022-03-28  5:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-27 11:23 [PATCH v6 0/3] vimdiff: new implementation with layout support Fernando Ramos
2022-03-27 11:23 ` [PATCH v6 1/3] " Fernando Ramos
2022-03-27 16:47   ` Philippe Blain
2022-03-27 18:12     ` Fernando Ramos
2022-03-27 21:36   ` Junio C Hamano
2022-03-27 11:23 ` [PATCH v6 2/3] vimdiff: integrate layout tests in the unit tests framework ('t' folder) Fernando Ramos
2022-03-27 21:37   ` Junio C Hamano
2022-03-27 11:23 ` [PATCH v6 3/3] vimdiff: add tool documentation Fernando Ramos
2022-03-27 18:28   ` Philippe Blain
2022-03-27 18:50     ` [PATCH] fixup! " Philippe Blain
2022-03-27 21:10     ` [PATCH v6 3/3] " Fernando Ramos
2022-03-27 21:43       ` Junio C Hamano
2022-03-27 22:17         ` Fernando Ramos
2022-03-28  4:48   ` Bagas Sanjaya
2022-03-28  5:43     ` Junio C Hamano [this message]
2022-03-28 19:19       ` Fernando Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbkxq639i.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=bagasdotme@gmail.com \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=greenfoo@u92.eu \
    --cc=levraiphilippeblain@gmail.com \
    --cc=rogi@skylittlesystem.org \
    --cc=seth@eseth.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.