All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org, lenaic@lhuard.fr
Subject: Re: lh/use-gnu-color-in-grep, was Re: What's cooking in git.git (Jan 2022, #01; Mon, 3)
Date: Tue, 04 Jan 2022 12:11:06 -0800	[thread overview]
Message-ID: <xmqqbl0rcld1.fsf@gitster.g> (raw)
In-Reply-To: <25d00bcb-3345-c221-6a38-593f23f942f3@gmail.com> (Philippe Blain's message of "Tue, 4 Jan 2022 13:06:25 -0500")

Philippe Blain <levraiphilippeblain@gmail.com> writes:

>> FWIW I am in favor of adjusting Git's `grep` colors to GNU's
>> version. From
>> the users' perspective, it provides more consistency and less unexpected
>> surprises.
>
> For what it's worth, I'm also in favor of that change. It's been
> in my todo list of possible enhancements for a little while. I
> agree with Dscho that it's more consistent for users to have the
> same default colors as GNU grep.

I am not a huge fan of adjusting our defaults to other people's
default, since they can match ours to "have the same default", if
they wanted to.  Also we are risking complaints from those who would
say "We've been happily using the default coloring, and you suddenly
changed it to something ugly. We want our color back and we do not
care that now you match what GNU does".

But it seems that I won't have to be the one who need to field such
complaints, and instead we have at least two well-known people in
the list who volunteered for the role, so let's take it as-is.




  reply	other threads:[~2022-01-04 20:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04  3:46 What's cooking in git.git (Jan 2022, #01; Mon, 3) Junio C Hamano
2022-01-04 12:23 ` jl/subtree-check-parents-argument-passing-fix, was " Johannes Schindelin
2022-01-04 20:05   ` Junio C Hamano
2022-01-04 13:59 ` lh/use-gnu-color-in-grep, " Johannes Schindelin
2022-01-04 18:06   ` Philippe Blain
2022-01-04 20:11     ` Junio C Hamano [this message]
2022-01-04 17:32 ` tb/midx-bitmap-corruption-fix (was: What's cooking in git.git (Jan 2022, #01; Mon, 3)) Taylor Blau
2022-01-04 20:13   ` tb/midx-bitmap-corruption-fix Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbl0rcld1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=lenaic@lhuard.fr \
    --cc=levraiphilippeblain@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.