All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>, "Jeff King" <peff@peff.net>,
	"Thomas Rast" <tr@thomasrast.ch>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 0/9] Teach 'run' perf script to read config files
Date: Sun, 24 Sep 2017 16:59:54 +0900	[thread overview]
Message-ID: <xmqqbmm0h6h1.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAP8UFD2j-UFh+9awz91gtZ-jusq7EUOExMgURO59vpf29jXS4A@mail.gmail.com> (Christian Couder's message of "Sat, 23 Sep 2017 21:39:02 +0200")

Christian Couder <christian.couder@gmail.com> writes:

> (It looks like smtp.gmail.com isn't working anymore for me, so I am
> trying to send this using Gmail for the cover letter and Submitgit for
> the patches.)

SubmitGit may want to learn the "change the timestamps of the
individual patches by 1 second" trick from "git send-email" to help
threading (you can view inbox/comp.version-control.git/ group over
nntp and tell your newsreader to sort-by-date).

> Highlevel view of the patches in the series
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>   - Patches 1/9 to 4/9 were already in v1 and haven't changed.

It isn't quite clear what _did_ change in the series and what
lessons were learned form the previous round's discussion here.  The
sample configuration in the description above (snipped) seems to
have been extended and it shows that one of the use cases of the
feature is to allow comparing runs against two versions, which
looked more or less sensible way to express it.

> Christian Couder (9):
>   perf/run: add '--config' option to the 'run' script
>   perf/run: add get_var_from_env_or_config()
>   perf/run: add GIT_PERF_DIRS_OR_REVS
>   perf/run: add calls to get_var_from_env_or_config()
>   perf/run: add get_subsections()
>   perf/run: update get_var_from_env_or_config() for subsections
>   perf/run: add run_subsection()
>   perf/run: show name of rev being built
>   perf: store subsection results in "test-results/$GIT_PERF_SUBSECTION/"
>
>  t/perf/aggregate.perl | 11 +++++--
>  t/perf/perf-lib.sh    |  4 +--
>  t/perf/run            | 89 +++++++++++++++++++++++++++++++++++++++++++++------
>  3 files changed, 89 insertions(+), 15 deletions(-)

Thanks.  Let me see how well it works ;-)

  reply	other threads:[~2017-09-24  8:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-23 19:39 [PATCH v2 0/9] Teach 'run' perf script to read config files Christian Couder
2017-09-24  7:59 ` Junio C Hamano [this message]
2017-09-26 15:40   ` Christian Couder
2017-09-26 19:33     ` Roberto Tyley
2017-09-26 19:38       ` Stefan Beller
2017-09-27  0:04       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbmm0h6h1.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=tr@thomasrast.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.