Re: [PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0

From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Tom G. Christensen" <tgc@jupiterrise.com>, git@vger.kernel.org
Subject: Re: [PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0
Date: Wed, 12 Apr 2017 23:28:28 -0700	[thread overview]
Message-ID: <xmqqbms0q0s3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170406091857.hl4ndn52kj2z4ujh@sigill.intra.peff.net> (Jeff King's message of "Thu, 6 Apr 2017 05:18:57 -0400")

Jeff King <peff@peff.net> writes:

> On Wed, Apr 05, 2017 at 03:04:24PM +0200, Tom G. Christensen wrote:
> ...
> These kinds of interleaved conditionals make me nervous that we'll get
> something wrong (especially without braces, it's not immediately clear
> that both sides are a single statement).
>
> I wonder if it would be more readable to do something like:
>
>   #if LIBCURL_VERSION_NUM < 0x070c00
>   static const char *curl_easy_strerror(CURL *curl)
>   {
> 	return "[error code unavailable; curl version too old]";
>   }
>   #endif
>
> Then callers don't have to individually deal with the ifdef. It does
> mean that the user sees that kind-of ugly message, but maybe that is a
> good thing. They know they need to upgrade curl to see more details.

Yup, thanks for a very good suggestion.