All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Duy Nguyen <pclouds@gmail.com>, Noel Grandin <noel@peralex.com>,
	git <git@vger.kernel.org>
Subject: Re: feature request: excluding files/paths from "git grep"
Date: Wed, 25 Feb 2015 11:01:22 -0800	[thread overview]
Message-ID: <xmqqbnkholx9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150225185128.GA16569@peff.net> (Jeff King's message of "Wed, 25 Feb 2015 13:51:28 -0500")

Jeff King <peff@peff.net> writes:

> So I think _if_ using "diff" attributes is enough for this purpose, then
> there is no code to be written.  But if somebody wants to draw a
> distinction between the uses (I want to diff "foo" files, but never see
> them in grep) then we could introduce a "grep" attribute (with the
> fallback being the value of the "diff" attribute for that path).

That is all true.

If we were to have a new 'grep' attribute that can be used to
express 'It is OK to diff two versions of this path, but hits by
grep in this path is useless' (and verse versa), the built-in macro
attribute 'binary' should also be updated with it.  A path being
'binary' currently means '-diff -merge -text' but it should also
mean '-grep' in the new world, if we were to go in that direction.

Thanks.

  reply	other threads:[~2015-02-25 19:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 12:23 feature request: excluding files/paths from "git grep" Noel Grandin
2015-02-25 13:46 ` Duy Nguyen
2015-02-25 14:31   ` Jeff King
2015-02-25 18:33     ` Junio C Hamano
2015-02-25 18:51       ` Jeff King
2015-02-25 19:01         ` Junio C Hamano [this message]
2015-02-25 19:11           ` Jeff King
2015-02-26 11:16             ` Michael J Gruber
2015-02-26 11:58               ` Duy Nguyen
2015-02-26 20:59               ` Junio C Hamano
2015-02-27 15:13                 ` Michael J Gruber
2015-02-27 19:17                   ` Junio C Hamano
2015-02-27 10:04             ` Trevor Saunders
2015-03-01  3:06               ` Junio C Hamano
2015-03-01 13:03                 ` Trevor Saunders
2015-03-01 23:22                   ` Junio C Hamano
2015-03-02 12:50                     ` Trevor Saunders
2015-03-04 11:25                       ` Noel Grandin
2015-03-04 20:56                         ` Junio C Hamano
2015-03-05  5:22                           ` Jeff King
2015-03-05  6:03                             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbnkholx9.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=noel@peralex.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.