Re: [PATCH v2 0/2] improve interactive-patch

From: Junio C Hamano <gitster@pobox.com>
To: "Rubén Justo" <rjusto@gmail.com>
Cc: Phillip Wood <phillip.wood123@gmail.com>,
	 Git List <git@vger.kernel.org>,
	 Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2 0/2] improve interactive-patch
Date: Tue, 26 Mar 2024 12:13:46 -0700	[thread overview]
Message-ID: <xmqqcyrgajrp.fsf@gitster.g> (raw)
In-Reply-To: <eabf30e0-091e-475a-b59f-16b1091763ed@gmail.com> (=?utf-8?Q?=22Rub=C3=A9n?= Justo"'s message of "Tue, 26 Mar 2024 19:48:24 +0100")

Rubén Justo <rjusto@gmail.com> writes:

> On Tue, Mar 26, 2024 at 08:31:41AM -0700, Junio C Hamano wrote:
>
>> 'r'edisplay may work well (and I wonder "r | less" or
>> piping the hunk display to anything in general would be a useful
>> future enhancement).
>
> Yeah.  That's a very good enhancement.
>
> However, I'm not sure how.  Perhaps with the help of git-diff-files(1)?

It is perfectly OK that you are not sure, as I do not think I am,
either.  I am reasonably sure "git diff-files" wouldn't be involved,
though ;-)  It would be more like tweaking fputs() of a strbuf that
was filled by render_hunk() to instead spawn a pager and feed the
same strbuf to it, or something.  IOW, we already have the payload
to show.  We just want a pager involved in its showing so that users
with a huge hunk that does not fit on a page can use "less" on it.

In any case, the future enhancement is not within, and we shouldn't
add it to, the scope of this topic.