From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: aidgal2@gmail.com, git@vger.kernel.org, Thomas Rast <tr@thomasrast.ch>
Subject: Re: Formatting options are ignored when tracking functions
Date: Mon, 24 May 2021 03:11:53 +0900 [thread overview]
Message-ID: <xmqqczthnwuu.fsf@gitster.g> (raw)
In-Reply-To: EE7D39E6-D826-49E2-AD0E-090A83DFDEC1@gmail.com
Philippe Blain <levraiphilippeblain@gmail.com> writes:
> I believe this is working as advertised: only the first line of
> the commit message is shown.
> However as mentioned in the doc, the -L option also triggers patch
> output (-p), which you can omit if you explicitely add --no-patch
> (or shorter, -s).
Heh, I think "working as advertised" is not wrong per-se, but this
feels like a clear design mistake to me, at least at the UI level.
Admittedly, I've never used "log -L" in scripts and I've always used
it interactively, in a context that I want to see the patch output,
so this did not bother me so far.
But what commits -L decides have relevant changes and how these
commits are shown ought to be orthogonal. It surely may need to run
the content-level diff machinery to see if each commit affects the
area of the code specified via the -L option, but just like "git log
-S<text>" can be used to find commits that change the number of
occurrences of <text>, and allows the users to choose to view them
with "-p" (but not force the --patch mode on), it should behave the
same way, I would think.
With a clear migration plan, we should be able to fix this over
time, I would think.
next prev parent reply other threads:[~2021-05-23 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 1:58 Formatting options are ignored when tracking functions Philippe Blain
2021-05-22 3:55 ` Bagas Sanjaya
2021-05-23 18:11 ` Junio C Hamano [this message]
2021-05-23 18:20 ` Philippe Blain
2021-05-23 19:28 ` Felipe Contreras
-- strict thread matches above, loose matches on Subject: below --
2021-05-21 21:18 Aidan
2021-05-23 2:28 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczthnwuu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aidgal2@gmail.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.