From: Junio C Hamano <gitster@pobox.com>
To: Miriam Rubio <mirucam@gmail.com>
Cc: git@vger.kernel.org, Pranit Bauva <pranit.bauva@gmail.com>,
Lars Schneider <larsxschneider@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Tanushree Tumane <tanushreetumane@gmail.com>
Subject: Re: [PATCH v4 7/7] bisect--helper: retire `--check-and-set-terms` subcommand
Date: Thu, 28 Jan 2021 16:49:59 -0800 [thread overview]
Message-ID: <xmqqczxova6g.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20210125191710.45161-8-mirucam@gmail.com> (Miriam Rubio's message of "Mon, 25 Jan 2021 20:17:10 +0100")
Miriam Rubio <mirucam@gmail.com> writes:
> From: Pranit Bauva <pranit.bauva@gmail.com>
>
> The `--check-and-set-terms` subcommand is no longer from the
> git-bisect.sh shell script. Instead the function
> `check_and_set_terms()` is called from the C implementation.
Nice to see these intermediate state going away.
Reviewers and mentors, how close do you folks think these patches
are to the completion? It looks quite good to me (admittedly I gave
only a cursory look to these recent iterations).
Thanks.
next prev parent reply other threads:[~2021-01-29 0:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 19:17 [PATCH v4 0/7] Finish converting git bisect to C part 3 Miriam Rubio
2021-01-25 19:17 ` [PATCH v4 1/7] bisect--helper: reimplement `bisect_log` shell function in C Miriam Rubio
2021-01-30 1:46 ` Đoàn Trần Công Danh
2021-01-30 9:49 ` Christian Couder
2021-01-25 19:17 ` [PATCH v4 2/7] bisect--helper: reimplement `bisect_replay` " Miriam Rubio
2021-01-29 7:51 ` Christian Couder
2021-01-25 19:17 ` [PATCH v4 3/7] bisect--helper: retire `--bisect-write` subcommand Miriam Rubio
2021-01-29 7:54 ` Christian Couder
2021-01-25 19:17 ` [PATCH v4 4/7] bisect--helper: use `res` instead of return in BISECT_RESET case option Miriam Rubio
2021-01-29 7:57 ` Christian Couder
2021-01-25 19:17 ` [PATCH v4 5/7] bisect--helper: retire `--bisect-auto-next` subcommand Miriam Rubio
2021-01-25 19:17 ` [PATCH v4 6/7] bisect--helper: reimplement `bisect_skip` shell function in C Miriam Rubio
2021-01-25 19:17 ` [PATCH v4 7/7] bisect--helper: retire `--check-and-set-terms` subcommand Miriam Rubio
2021-01-29 0:49 ` Junio C Hamano [this message]
2021-01-26 17:55 ` [PATCH v4 0/7] Finish converting git bisect to C part 3 Junio C Hamano
2021-01-26 18:27 ` Miriam R.
2021-01-26 20:05 ` Junio C Hamano
2021-01-26 22:32 ` Junio C Hamano
2021-01-27 14:12 ` Miriam R.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczxova6g.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=mirucam@gmail.com \
--cc=pranit.bauva@gmail.com \
--cc=tanushreetumane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.