From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview) Date: Fri, 12 Sep 2014 13:47:42 -0700 Message-ID: References: <20140820231723.GF20185@google.com> <20140911030318.GD18279@google.com> <20140912004717.GY18279@google.com> <20140912191812.GZ18279@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ronnie Sahlberg , "git\@vger.kernel.org" , Michael Haggerty To: Jonathan Nieder X-From: git-owner@vger.kernel.org Fri Sep 12 22:47:51 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XSXl0-0004fY-Uc for gcvg-git-2@plane.gmane.org; Fri, 12 Sep 2014 22:47:51 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbaILUrr (ORCPT ); Fri, 12 Sep 2014 16:47:47 -0400 Received: from smtp.pobox.com ([208.72.237.35]:52526 "EHLO smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbaILUrq (ORCPT ); Fri, 12 Sep 2014 16:47:46 -0400 Received: from smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 390B739753; Fri, 12 Sep 2014 16:47:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=TZtwPJUai7SVMoq7ZVB3eGM3P7c=; b=mB2uQT JHPmS94JgNa0nhU9iH6AcN+7vWBKrzl/0TzW3HZxxLm6zLfpX+g2KjKeTl3GV047 o0x8gWbiG++Bvj80V3HMFdWWGVTrl4hCF732SIxgRHnK0NKldR7umbP+js4KIWok TmexZ5lk2onjtzN6P9/ooy7yymppofLw4Mvxk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=mIp7Op62BVpKw8/ICSlW+zaSRG5STDHZ 3xG0rtZ14XksqkSjx+vGaauiKNnptdue3aAB5OSkgUmLnX6mgeRwEdgEROZ0Vjv8 HLrZlhpxHo7mpAoezjAuR/C6evIElUPbk1RJ2nO77evnnZAZDg7Q9kkRDyBQBrkm 6nHURmRUjio= Received: from pb-smtp0. (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 2E4CC39752; Fri, 12 Sep 2014 16:47:45 -0400 (EDT) Received: from pobox.com (unknown [72.14.226.9]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp0.pobox.com (Postfix) with ESMTPSA id 9999339751; Fri, 12 Sep 2014 16:47:44 -0400 (EDT) In-Reply-To: (Junio C. Hamano's message of "Fri, 12 Sep 2014 12:56:52 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-Pobox-Relay-ID: 0BEFB07A-3ABE-11E4-9B3E-BD2DC4D60FE0-77302942!pb-smtp0.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano writes: > Jonathan Nieder writes: > >> It's "Oops, the next one (refs.c: do not permit err == NULL) is broken, >> and this is to patch it up in advance". :) >> >> But it should apply on top, too. > > I think "in advance" makes sense for this one, too. > >> There were a few other minor changes, and I think with them the series >> should be ready for "next". My "send and hope that more reviewers >> appear" strategy didn't really work,... > > You sent them just a few days ago. Expecting anybody to have a > solid time to sit thru a 19-patch series inside that timeframe is > not so realistic. > >> so I'll send a reroll of the series as-is in an hour or so. > > OK. Thanks. I do not think I have enough time to pick a reroll up to redo the day's integration, so please take time to make it perfect. I noticed that with this series merged to the version I use daily, detaching HEAD (i.e. "git checkout HEAD^0") breaks my HEAD reflog, which made me redo the integration ejecting the series out of 'pu'. Not happy, as my workflow relies fairly heavily on detached HEAD X-<.