From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3 2/2] commit: add --ignore-submodules[=<when>] parameter
Date: Mon, 14 Apr 2014 11:30:09 -0700
Message-ID: <xmqqd2gjpxvy.fsf@gitster.dls.corp.google.com>
References: <CABxC_L92v=cV=+e_DNa0L6f21LB0BRP5duai2h_heGJN_PRoUQ@mail.gmail.com>
	<5335A78C.60401@web.de>
	<CABxC_L-4=qcZiix05dL8GrDJXv=19fw4yB0qFzRRfw=G=_Gxbg@mail.gmail.com>
	<53374E49.9000702@gmail.com> <533874F9.3090802@web.de>
	<5338AC36.6000109@gmail.com> <5338B1B0.3050703@gmail.com>
	<5339BAE4.8020306@web.de>
	<CABxC_L8_tQrANXji_Z0LfigxsAuzSDj3K9ndTGOTHh2ctHvc6A@mail.gmail.com>
	<5339F122.60801@gmail.com> <5339FBB4.1010101@gmail.com>
	<533B2036.3050506@web.de> <533B36AA.3090600@gmail.com>
	<533C5CBD.4050601@web.de> <533C6B57.3080901@gmail.com>
	<534180BC.308@web.de> <53431CB8.2050600@gmail.com>
	<53432EA5.5060102@gmail.com> <53444368.9050607@web.de>
	<5349BC2C.9030509@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jens Lehmann <Jens.Lehmann@web.de>, git@vger.kernel.org,
	Heiko Voigt <hvoigt@hvoigt.net>
To: Ronald Weiss <weiss.ronald@gmail.com>
X-From: git-owner@vger.kernel.org Mon Apr 14 20:30:26 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WZleD-0006zn-R1
	for gcvg-git-2@plane.gmane.org; Mon, 14 Apr 2014 20:30:26 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754936AbaDNSaQ (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Mon, 14 Apr 2014 14:30:16 -0400
Received: from b-pb-sasl-quonix.pobox.com ([208.72.237.35]:62909 "EHLO
	smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751462AbaDNSaN (ORCPT <rfc822;git@vger.kernel.org>);
	Mon, 14 Apr 2014 14:30:13 -0400
Received: from smtp.pobox.com (unknown [127.0.0.1])
	by b-sasl-quonix.pobox.com (Postfix) with ESMTP id DA7607C675;
	Mon, 14 Apr 2014 14:30:12 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
	:subject:references:date:in-reply-to:message-id:mime-version
	:content-type; s=sasl; bh=HFo8CnIWfqznVXDRwc0fen4uEDs=; b=xrxQu6
	fI7cHxtUgaGulEzqr+fkClECbiU1b4vSa68zQ5VqVkiwhowxKvfbRH0ud2rpRhvN
	mf0veIx60Oh9mq8AKCp2XIdGWz5IIwx+knuwxwdOY/3C/dipC/OhecqNk2VOa3Zc
	8Uat58d0pa1c0CrdCUgyhq/6UNw24ILmog9X4=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
	:subject:references:date:in-reply-to:message-id:mime-version
	:content-type; q=dns; s=sasl; b=mti+YJB8cPIKtxe7IW7+/c667XEEJbWq
	Z05AsemLGVdhj5n9LRjH9TV6em3w2cF5ebmU1KkvXk58UnCAxqC2XwcEd/4HdDk8
	kl8qBCLGAnBKbS6OCFu+DX1sQwnOF8oq2uUCfTANhMW8FICbswKeT88SG8ItK1KM
	3U7caPgSOjw=
Received: from b-pb-sasl-quonix.pobox.com (unknown [127.0.0.1])
	by b-sasl-quonix.pobox.com (Postfix) with ESMTP id BA6517C674;
	Mon, 14 Apr 2014 14:30:12 -0400 (EDT)
Received: from pobox.com (unknown [72.14.226.9])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by b-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 5CC657C671;
	Mon, 14 Apr 2014 14:30:11 -0400 (EDT)
In-Reply-To: <5349BC2C.9030509@gmail.com> (Ronald Weiss's message of "Sun, 13
	Apr 2014 00:20:28 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
X-Pobox-Relay-ID: D03FB82C-C402-11E3-8A1C-8D19802839F8-77302942!b-pb-sasl-quonix.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/246253>

Ronald Weiss <weiss.ronald@gmail.com> writes:

> On 8. 4. 2014 20:43, Jens Lehmann wrote:
>>> Useful <when> values for commit are 'all' (default) or 'none'. The others
>>> ('dirty' and 'untracked') have same effect as 'none', as commit is only
>>> interested in whether the submodule's HEAD differs from what is commited
>>> in the superproject.
>>
>> Unless it outputs a status message, then 'dirty' and 'untracked' do
>> influence what is shown there. Apart from that (and maybe tests for
>> these two cases ;-) this is looking good to me.
>
> OK, I updated the patch for commit to take that into account. Also, I
> rebased both patches onto current master. Sending them in a moment.
>
> If you don't have any more complaints, can I add "Acked-by: <you>" and
> resend the patches to Junio?

It is not "When I see no more complaints, I'll resend with your
Ack".  An Ack is a positive thing, not lack of discovery of further
issues.

Rather, it is more like "I'll wait for your Acks and then I'll
resend with your Ack", or "If they look good, reply with Ack and let
the maintainer pick them up".

Thanks.