All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Glen Choo <chooglen@google.com>
Cc: Orgad Shaneh via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Orgad Shaneh <orgads@gmail.com>
Subject: Re: [PATCH v2] submodule--helper: fix initialization of warn_if_uninitialized
Date: Wed, 27 Apr 2022 16:20:49 -0700	[thread overview]
Message-ID: <xmqqee1ijepa.fsf@gitster.g> (raw)
In-Reply-To: <kl6lfslyp3ti.fsf@chooglen-macbookpro.roam.corp.google.com> (Glen Choo's message of "Wed, 27 Apr 2022 15:19:21 -0700")

Glen Choo <chooglen@google.com> writes:

> "Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com> writes:
>> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
>> index 2c87ef9364f..1a8e5d06214 100644
>> --- a/builtin/submodule--helper.c
>> +++ b/builtin/submodule--helper.c
>> @@ -2026,7 +2026,6 @@ struct update_data {
>>  	.references = STRING_LIST_INIT_DUP, \
>>  	.single_branch = -1, \
>>  	.max_jobs = 1, \
>> -	.warn_if_uninitialized = 1, \
>>  }
>>  
>>  static void next_submodule_warn_missing(struct submodule_update_clone *suc,
>>
>> base-commit: 6cd33dceed60949e2dbc32e3f0f5e67c4c882e1e
>> -- 
>> gitgitgadget
>
> This was clearly a mistake on my part :( The fix looks good to me,
> thanks!

Will merge the fix down in preparation for 2.36.1 and later.

Thanks, both.

      reply	other threads:[~2022-04-27 23:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-24  6:26 [PATCH] submodule--helper: fix initialization of warn_if_uninitialized Orgad Shaneh via GitGitGadget
2022-04-25  9:34 ` Junio C Hamano
2022-04-25 12:43   ` Orgad Shaneh
2022-04-25 12:45 ` [PATCH v2] " Orgad Shaneh via GitGitGadget
2022-04-25 18:25   ` Junio C Hamano
2022-04-25 20:56     ` Junio C Hamano
2022-04-27 22:22       ` Glen Choo
2022-04-27 22:23       ` Glen Choo
2022-04-27 22:25       ` Glen Choo
2022-04-27 22:19   ` Glen Choo
2022-04-27 23:20     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqee1ijepa.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chooglen@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=orgads@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.