All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Azeem Bande-Ali via GitGitGadget" <gitgitgadget@gmail.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
	git@vger.kernel.org, David Barr <b@rr-dav.id.au>,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	Azeem Bande-Ali <me@azeemba.com>,
	Azeem Bande-Ali <A.BandeAli@gmail.com>
Subject: Re: [PATCH v3] help.c: help.autocorrect=prompt waits for user action
Date: Tue, 07 Sep 2021 17:18:16 -0700	[thread overview]
Message-ID: <xmqqee9z9ayf.fsf@gitster.g> (raw)
In-Reply-To: <pull.1012.v3.git.1628992226139.gitgitgadget@gmail.com> (Azeem Bande-Ali via GitGitGadget's message of "Sun, 15 Aug 2021 01:50:26 +0000")

"Azeem Bande-Ali via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Azeem Bande-Ali <me@azeemba.com>
>
> If help.autocorrect is set to 'prompt', the user is prompted
> before the suggested action is executed.
>
> Based on original patch by David Barr
> https://lore.kernel.org/git/1283758030-13345-1-git-send-email-david.barr@cordelta.com/
>
> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
> Signed-off-by: Azeem Bande-Ali <me@azeemba.com>
> ---
>     New config for help.autocorrect to prompt user before action
>     
>     Only minor style changes have been made since v2:
>     
>      * Moved * to variable name instead of the type name
>      * Keep code in the same line for readability

I didn't see anybody comment on this round (and do not think I saw
anything glaringly wrong).

Is everybody happy with this version?  I am about to mark it for
'next' in the next issue of "What's cooking" report, so please
holler if I should wait.

Thanks.

      reply	other threads:[~2021-09-08  0:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  0:15 [PATCH] help.c: help.autocorrect=prompt waits for user action Azeem Bande-Ali via GitGitGadget
2021-08-12 10:52 ` Bagas Sanjaya
2021-08-14  2:57   ` Azeem Bande-Ali
2021-08-12 19:37 ` Junio C Hamano
2021-08-14  3:07   ` Azeem Bande-Ali
2021-08-14  5:11 ` [PATCH v2] " Azeem Bande-Ali via GitGitGadget
2021-08-14  5:50   ` Bagas Sanjaya
2021-08-14 18:20   ` Junio C Hamano
2021-08-14 18:40     ` Azeem Bande-Ali
2021-08-16 12:28     ` Johannes Schindelin
2021-08-15  1:50   ` [PATCH v3] " Azeem Bande-Ali via GitGitGadget
2021-09-08  0:18     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqee9z9ayf.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=A.BandeAli@gmail.com \
    --cc=b@rr-dav.id.au \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=me@azeemba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.