All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
	"Michael Rappazzo" <rappazzo@gmail.com>,
	"Duy Nguyen" <pclouds@gmail.com>,
	"SZEDER Gábor" <szeder@ira.uka.de>,
	"Johannes Sixt" <j.sixt@viscovery.net>
Subject: Re: [PATCH 0/6] modernize t1500
Date: Tue, 10 May 2016 11:26:32 -0700	[thread overview]
Message-ID: <xmqqeg99py5j.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqmvnxpyw6.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Tue, 10 May 2016 11:10:33 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Eric Sunshine <sunshine@sunshineco.com> writes:
>>
>>> This series modernizes t1500; it takes an entirely different approach
>>> than [1][2] and is intended to replace that series.
>>
>> Turns out that it wasn't so painful after all.
>>
>> The only small niggle I have is on 6/6; my preference would be,
>> because once we set up .git we do not add objects and refs to it, to
>> make a copy a lot earlier before the tests start.
>
> -- >8 --
> Subject: [PATCH 7/6] t1500: finish preparation upfront
>
> The earlier tests do not attempt to modify the contents of .git (by
> creating objects or refs, for example), which means that even if
> some earlier tests before "cp -R" fail, the tests in repo.git will
> run in an environment that we can expect them to succeed in.
>
> Make it clear that tests in repo.git will be independent from the
> results of earlier tests done in .git by moving its initialization
> "cp -R .git repo.git" much higher in the test sequence.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---

I think the same logic applies to other preparatory things like
creation of sub/dir in the working tree etc.

  reply	other threads:[~2016-05-10 18:26 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10  5:20 [PATCH 0/6] modernize t1500 Eric Sunshine
2016-05-10  5:20 ` [PATCH 1/6] t1500: test_rev_parse: facilitate future test enhancements Eric Sunshine
2016-05-10  5:20 ` [PATCH 2/6] t1500: reduce dependence upon global state Eric Sunshine
2016-05-10  5:20 ` [PATCH 3/6] t1500: avoid changing working directory outside of tests Eric Sunshine
2016-05-10  5:20 ` [PATCH 4/6] t1500: avoid setting configuration options " Eric Sunshine
2016-05-10  6:34   ` Eric Sunshine
2016-05-10 18:02     ` Junio C Hamano
2016-05-10  5:20 ` [PATCH 5/6] t1500: avoid setting environment variables " Eric Sunshine
2016-05-10 18:39   ` Jeff King
2016-05-10 19:12     ` Eric Sunshine
2016-05-10 19:19       ` Junio C Hamano
2016-05-10 19:48       ` Eric Sunshine
2016-05-10 19:59         ` Eric Sunshine
2016-05-10 20:41           ` Jeff King
2016-05-10 20:07         ` Junio C Hamano
2016-05-10 21:01         ` SZEDER Gábor
2016-05-10 21:11           ` Junio C Hamano
2016-05-10 21:19             ` Eric Sunshine
2016-05-10  5:20 ` [PATCH 6/6] t1500: be considerate to future potential tests Eric Sunshine
2016-05-10  6:07 ` [PATCH 0/6] modernize t1500 Junio C Hamano
2016-05-10 18:10   ` Junio C Hamano
2016-05-10 18:26     ` Junio C Hamano [this message]
2016-05-16 17:39       ` Eric Sunshine
2016-05-16 18:52         ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2016-02-29  6:30 50a6c8ef - xmalloc_array Torsten Bögershausen
2016-02-29  9:28 ` [PATCH] compat/mingw: brown paper bag fix for 50a6c8e Jeff King
2016-02-29  9:56   ` Torsten Bögershausen
2016-02-29 10:02     ` Jeff King
2016-02-29 10:40       ` Compiler warning under cygwin/mingw (was: fix for 50a6c8e) Torsten Bögershausen
2016-02-29 10:47         ` Jeff King
2016-02-29 14:05           ` SZEDER Gábor
2016-04-12 23:20             ` Compiler warning under cygwin/mingw Junio C Hamano
2016-05-10 18:29             ` [PATCH 0/6] modernize t1500 Junio C Hamano
2016-02-29 12:32         ` Compiler warning under cygwin/mingw Ramsay Jones
2016-03-03  3:33           ` Ramsay Jones
2016-03-03  5:25             ` Ramsay Jones
2016-02-29 19:10       ` [PATCH] compat/mingw: brown paper bag fix for 50a6c8e Junio C Hamano
2016-02-29 21:36         ` Jeff King
2016-03-01  5:49           ` Torsten Bögershausen
2016-03-01  5:54             ` Jeff King
2016-03-01 13:52               ` Johannes Schindelin
2016-02-29 13:01   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeg99py5j.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=rappazzo@gmail.com \
    --cc=sunshine@sunshineco.com \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.