From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B798C07E99 for ; Fri, 9 Jul 2021 18:41:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4476F613C2 for ; Fri, 9 Jul 2021 18:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229506AbhGISoW (ORCPT ); Fri, 9 Jul 2021 14:44:22 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:63188 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbhGISoW (ORCPT ); Fri, 9 Jul 2021 14:44:22 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id DBFEBE251E; Fri, 9 Jul 2021 14:41:37 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=AF17XCzNRcbhqwhaX82ipCOeLU70B/QABDeG1n kJBbI=; b=XIHw4XTnBEqAwtbJdAbtjHE9g40TKlV90k7Zbkg+wg8PeRMMUGDDQv hB1ykZTG3aDqTQjzkammfmvYw2pa4yXaSjtZ9eeUYNUyr9Pn4vVcS+1V7Qa1qHBW KC1isAJJNfI9h6AqA/bPW7j2Af7jkmjZzjI19G07SpjVdtSyd7GfI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id CD544E251D; Fri, 9 Jul 2021 14:41:37 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.3.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 502A2E251C; Fri, 9 Jul 2021 14:41:37 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Avishay Matayev Cc: git@vger.kernel.org, code@tpope.net Subject: Re: [PATCH 2/3] Allow isatty to be overriden with GIT_FORCE_TTY References: <20210706210317.706313-1-me@avishay.dev> <20210706210317.706313-3-me@avishay.dev> Date: Fri, 09 Jul 2021 11:41:36 -0700 In-Reply-To: (Avishay Matayev's message of "Fri, 9 Jul 2021 20:24:15 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 4AE341AA-E0E5-11EB-B255-8B3BC6D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Avishay Matayev writes: >> > If you don't find the approach in this patch good enough, what exactly >> > do you suggest? >> >> Start with not tying this feature with the word "TTY", probably. > Well then, what are other indicators of 'interactivity' besides "TTY"? If we want to force output to always go through the pager, we should call it "force pager", not "force tty". If we want to always show progress bar no matter where the output goes, we should call it "force progress", not "force tty". These should be controllable independenty, even though it is OK to have catch all "force everything" for convenience. There is no inherent reason why the output has to be passed through the pager when it goes to tty. It merely is how we happen to have designed the heuristics. We don't want to carve it in stone and expose it on end-users with a poorly chosen name. Also, we do not want to tie multiple features unnecessarily.