Re: [PATCH v5 0/6] stash: support pathspec argument

From: Junio C Hamano <gitster@pobox.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Øyvind A . Holm" <sunny@sunbase.org>,
	"Jakub Narębski" <jnareb@gmail.com>,
	"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v5 0/6] stash: support pathspec argument
Date: Fri, 17 Feb 2017 15:01:33 -0800	[thread overview]
Message-ID: <xmqqfujcpgky.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170217224141.19183-1-t.gummerer@gmail.com> (Thomas Gummerer's message of "Fri, 17 Feb 2017 22:41:35 +0000")

Thomas Gummerer <t.gummerer@gmail.com> writes:

[some people may see this message twice, as I forgot to check if the
copy I received had "Some A . Body" not enclosed in dq; blindly
doing "Reply-All" ended up listing an invalid address on my Cc: line
and dropped by vger. apologies]

> diff --git a/git-stash.sh b/git-stash.sh
> index a184b1e274..1446fbe2e8 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -67,51 +67,20 @@ create_stash () {
>  		case "$1" in
>  		-m|--message)
>  			shift
> -			test -z ${1+x} && usage
> -			stash_msg="$1"
> -			new_style=t
> +			stash_msg=${1-"BUG: create_stash () -m requires an argument"}
>  			;;

Did you mean ${1?"BUG: ..."} here and also "-u" below?

>  		-u|--include-untracked)
>  			shift
> -			test -z ${1+x} && usage
> -			untracked="$1"
> -			new_style=t
> +			untracked=${1-"BUG: create_stash () -u requires an argument"}
>  			;;

Other than that the whole series looked sensible to me.

Thanks, will replace but that may not happen today.