From: Junio C Hamano <gitster@pobox.com>
To: kusmabite@gmail.com
Cc: Stepan Kasal <kasal@ucw.cz>, Johannes Sixt <j.sixt@viscovery.net>,
GIT Mailing-list <git@vger.kernel.org>,
Theodore Leblond <theodore.leblond@gmail.com>
Subject: Re: [PATCH v2] Sleep 1 millisecond in poll() to avoid busy wait
Date: Mon, 28 Apr 2014 11:58:50 -0700 [thread overview]
Message-ID: <xmqqfvkxqo0l.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CABPQNSbpyFzg8A8gLp2nJZeTRSLSb0Qs8ytZDsJLmi6VyER71Q@mail.gmail.com> (Erik Faye-Lund's message of "Mon, 28 Apr 2014 17:37:37 +0200")
Erik Faye-Lund <kusmabite@gmail.com> writes:
> On Mon, Apr 28, 2014 at 5:35 PM, Stepan Kasal <kasal@ucw.cz> wrote:
>> From: theoleblond <theodore.leblond@gmail.com>
>> Date: Wed, 16 May 2012 06:52:49 -0700
>>
>> ...
>> I also tested the very fast local case, and didn't see any measurable
>> difference. On a big repo with 4500 files, the upload-pack took about 2
>> seconds with and without the fix.
>> ---
>>
> Good stuff!
Do I expect to be forwarded this patch with proper provenance
sign-off chain thru you?
I do not mind adding Ack from you and J6t I saw in this thread
myself, perhaps like the following:
Subject: compat/poll: sleep 1 millisecond to avoid busy wait
From: Theodore Leblond <theodore.leblond@gmail.com>
SwitchToTrhead() only gives...
...
seconds with and without the fix.
Signed-off-by: Theodore Leblond <theodore.leblond@gmail.com>
Signed-off-by: Stepan Kasal <kasal@ucw.cz>
Acked-by: Johannes Sixt <j6t@kdbg.org>
Acked-by: Erik Faye-Lund <kusmabite@gmail.com>
I am just having this feeling that I lack the background on the
evolution of this patch to say the above properly records the
provenance.
Oh, also in the last paragraph, who is "I" who tested? Theodore, or
Stepan?
Thanks.
next prev parent reply other threads:[~2014-04-28 19:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 8:39 [PATCH] Sleep 1 millisecond in poll() to avoid busy wait Stepan Kasal
2014-04-28 9:07 ` Erik Faye-Lund
2014-04-28 11:38 ` Stepan Kasal
2014-04-28 11:42 ` [PATCH] poll/select: prevent busy-waiting Stepan Kasal
2014-04-28 11:44 ` Erik Faye-Lund
2014-04-28 14:29 ` [PATCH] Windows: Always normalize paths to Windows-style Stepan Kasal
2014-04-28 15:26 ` Stepan Kasal
2014-05-07 18:44 ` Heiko Voigt
2014-05-07 20:40 ` Junio C Hamano
2014-05-08 10:11 ` Stepan Kasal
2014-05-08 20:13 ` Junio C Hamano
2014-05-08 20:36 ` [PATCH] Revert "submodules: fix ambiguous absolute paths under Windows" Stepan Kasal
2014-04-28 15:05 ` [PATCH] poll/select: prevent busy-waiting Johannes Sixt
2014-04-28 15:35 ` [PATCH v2] Sleep 1 millisecond in poll() to avoid busy wait Stepan Kasal
2014-04-28 15:37 ` Erik Faye-Lund
2014-04-28 18:58 ` Junio C Hamano [this message]
2014-04-29 3:47 ` Stepan Kasal
2014-04-29 16:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvkxqo0l.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=kasal@ucw.cz \
--cc=kusmabite@gmail.com \
--cc=theodore.leblond@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.