From: Junio C Hamano <gitster@pobox.com>
To: Andreas Heiduk <asheiduk@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation: Link git-ls-files to core.quotePath variable.
Date: Tue, 21 Feb 2017 12:48:04 -0800 [thread overview]
Message-ID: <xmqqh93nfeyj.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <2b0ce702-60de-534b-8a86-5c7ae84060de@gmail.com> (Andreas Heiduk's message of "Sun, 19 Feb 2017 23:05:59 +0100")
Andreas Heiduk <asheiduk@gmail.com> writes:
> Add a hint for script writers where additional quoting can be configured.
>
> Signed-off-by: Andreas Heiduk <asheiduk@gmail.com>
> ---
> Documentation/git-ls-files.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt
> index 446209e..19e0636 100644
> --- a/Documentation/git-ls-files.txt
> +++ b/Documentation/git-ls-files.txt
> @@ -198,7 +198,8 @@ path. (see linkgit:git-read-tree[1] for more information on state)
>
> When `-z` option is not used, TAB, LF, and backslash characters
> in pathnames are represented as `\t`, `\n`, and `\\`,
> -respectively.
> +respectively. The path is also quoted according to the
> +configuration variable `core.quotePath` (see linkgit:git-config[1]).
I was waiting for others to comment on this patch but nobody seems
to be interested. Which is a bit sad, as this may not be a bad
idea.
If we refer to core.quotePath, the mention of control characters
being quoted can also be omitted, I think, as that is part of what
appears in the description of core.quotePath variable.
Alternatively, instead of referring to another page, we can spend
the additional lines to say what is more interesting to most of the
readers from that page, e.g.
When `-z` option is not used, a pathname with "unusual" characters
in it is quoted by enclosing it in a double-quote pair and with
backslashes the same way strings in C source code are quoted. By
setting core.quotePath configuration to false, the bytes whose
values are higher than 0x80 are output verbatim.
next prev parent reply other threads:[~2017-02-21 20:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 22:05 [PATCH] Documentation: Link git-ls-files to core.quotePath variable Andreas Heiduk
2017-02-21 20:48 ` Junio C Hamano [this message]
2017-02-22 1:20 ` Andreas Heiduk
2017-02-22 1:38 ` Andreas Heiduk
2017-02-22 12:21 ` Philip Oakley
2017-02-22 21:02 ` Junio C Hamano
2017-02-22 21:08 ` Andreas Heiduk
2017-02-24 20:37 ` [PATCH v2 0/2] " Andreas Heiduk
2017-02-24 20:37 ` [PATCH v2 1/2] Documentation: Improve description for core.quotePath Andreas Heiduk
2017-02-24 21:43 ` Jakub Narębski
2017-02-28 20:55 ` Andreas Heiduk
2017-02-24 20:37 ` [PATCH v2 2/2] Documentation: Link descriptions of -z to core.quotePath Andreas Heiduk
2017-02-24 21:54 ` Jakub Narębski
2017-02-28 21:30 ` Andreas Heiduk
2017-02-28 20:51 ` Junio C Hamano
2017-02-28 21:13 ` Andreas Heiduk
2017-02-28 21:25 ` Junio C Hamano
2017-02-22 17:41 ` [PATCH] Documentation: Link git-ls-files to core.quotePath variable Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh93nfeyj.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=asheiduk@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.