All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: larsxschneider@gmail.com
Cc: git@vger.kernel.org, luke@diamand.org, sunshine@sunshineco.com
Subject: Re: [PATCH v1 0/2] git-p4: kill watchdog and suppress irrelevant output
Date: Mon, 21 Dec 2015 12:31:37 -0800	[thread overview]
Message-ID: <xmqqh9jbfsra.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1450629869-49522-1-git-send-email-larsxschneider@gmail.com> (larsxschneider@gmail.com's message of "Sun, 20 Dec 2015 17:44:27 +0100")

larsxschneider@gmail.com writes:

> From: Lars Schneider <larsxschneider@gmail.com>
>
> Hi,
>
> these patches extend "git-p4: add trap to kill p4d on test exit" (dfe90e8)
> and therefore should be applied on master.

Wait, wait.  Please be a bit more careful when you use such a
phrasing.  Did somebody review these and said that these are
trivially correct improvements?

This depends on what you exactly meant "extend" and "improve" (for
the other one); if the "improvement" were to make something that
used to be unusable to usable, then the more sensible way forward
during the -rc stabilization period might be to revert the earlier
merges to 'master' that brought in undercooked topic.

Thanks.

>
> Thanks,
> Lars
>
> Lars Schneider (2):
>   git-p4: kill p4d watchdog on cleanup
>   git-p4: suppress non test relevant output
>
>  t/lib-git-p4.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> --
> 2.5.1

  parent reply	other threads:[~2015-12-21 20:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-20 16:44 [PATCH v1 0/2] git-p4: kill watchdog and suppress irrelevant output larsxschneider
2015-12-20 16:44 ` [PATCH v1 1/2] git-p4: kill p4d watchdog on cleanup larsxschneider
2015-12-20 16:44 ` [PATCH v1 2/2] git-p4: suppress non test relevant output larsxschneider
2015-12-21 20:38   ` Junio C Hamano
2015-12-22  8:47     ` Lars Schneider
2015-12-24 11:09       ` Luke Diamand
2015-12-21 20:31 ` Junio C Hamano [this message]
2015-12-22  9:12   ` [PATCH v1 0/2] git-p4: kill watchdog and suppress irrelevant output Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh9jbfsra.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    --cc=luke@diamand.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.