All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Löthberg" <johannes@kyriasis.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] upload-pack: Fail if cloning empty namespace
Date: Mon, 15 Jun 2015 13:49:38 -0700	[thread overview]
Message-ID: <xmqqh9q87l3x.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150612223223.GA22677@leeloo.kyriasis.com> ("Johannes =?utf-8?Q?L=C3=B6thberg=22's?= message of "Sat, 13 Jun 2015 00:32:23 +0200")

Johannes Löthberg <johannes@kyriasis.com> writes:

> On 13/06, Johannes Löthberg wrote:
>>Git should fail to clone if trying to clone from an non-existing
>>ref namespace, since it's the same as a non-existing repository
>>
>>Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
>>---
>>
>>Changes since v1:
>>
>>* Fixed the namespace check, since I apparently forgot to check with a
>>  bare repo in my last test. D'oh.
>>
>>Two other options for this would be to either add a
>>get_git_namespace_len() function and use that, or a is_namespaced()
>>functon. But since it's only used here for now at least it feels simpler
>>to not bloat the codabase with another function which has no other use.
>>
>
> I should note that I have a small test script written now, ready to be
> converted into a git test, though I want some opinions on whether the
> patch would be merged before bothering to convert it.

You would probably want new tests, but more importantly did you make
sure this passes existing tests?  It seems to break 5509 (there
could be others) at least for me.

  reply	other threads:[~2015-06-15 20:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12 20:15 [PATCH/RFC] upload-pack: Fail if cloning empty namespace Johannes Löthberg
2015-06-12 21:01 ` Junio C Hamano
2015-06-12 22:17 ` [PATCH v2] " Johannes Löthberg
2015-06-12 22:32   ` Johannes Löthberg
2015-06-15 20:49     ` Junio C Hamano [this message]
2015-06-20 14:27       ` Johannes Löthberg
2015-06-20 18:06         ` Junio C Hamano
2015-06-20 18:13           ` Johannes Löthberg
2015-06-20 21:20           ` Junio C Hamano
2015-06-20 21:49             ` Johannes Löthberg
2015-06-21 18:43               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh9q87l3x.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes@kyriasis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.