From: Junio C Hamano <gitster@pobox.com>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] docs: Clarify "preserve" option wording for git-pull
Date: Thu, 26 Mar 2015 10:37:54 -0700 [thread overview]
Message-ID: <xmqqh9t7zmkt.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAHGBnuMcKAhW+_Ho8X1kzZd3B57ogu2Anb1nuPmKwRQD=OYrZQ@mail.gmail.com> (Sebastian Schuberth's message of "Thu, 26 Mar 2015 12:04:23 +0100")
Sebastian Schuberth <sschuberth@gmail.com> writes:
> Before this path, the "also" sounded as if "preserve" was doing a rebase
> as additional work that "true" would not do. Clarify this by saying
> "still" instead of "also".
I agree that the original "also" is confusing. I however wonder if
we even want "still", though. For that matter, I doubt if we even
want "also" in front of "pass". "When set to preserve, rebase and
pass the extra flag" sounds as clear as, if not clearer than, "When
set to preserve, still rebase and also pass the extra flag", at
least to me.
Thanks.
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> ---
> Documentation/git-pull.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-pull.txt b/Documentation/git-pull.txt
> index d3d236c..96829be 100644
> --- a/Documentation/git-pull.txt
> +++ b/Documentation/git-pull.txt
> @@ -111,8 +111,8 @@ include::merge-options.txt[]
> was rebased since last fetched, the rebase uses that information
> to avoid rebasing non-local changes.
> +
> -When preserve, also rebase the current branch on top of the upstream
> -branch, but pass `--preserve-merges` along to `git rebase` so that
> +When preserve, still rebase the current branch on top of the upstream
> +branch, but also pass `--preserve-merges` along to `git rebase` so that
> locally created merge commits will not be flattened.
> +
> When false, merge the current branch into the upstream branch.
next prev parent reply other threads:[~2015-03-26 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 11:04 [PATCH] docs: Clarify "preserve" option wording for git-pull Sebastian Schuberth
2015-03-26 17:37 ` Junio C Hamano [this message]
2015-03-26 20:11 ` Sebastian Schuberth
2015-03-26 20:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh9t7zmkt.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.