Re: [PATCH v12 2/2] win32: close handles of threads that have been joined

From: Junio C Hamano <gitster@pobox.com>
To: "Seija Kijin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Johannes Sixt" <j6t@kdbg.org>, "René Scharfe" <l.s.r@web.de>,
	"Seija Kijin" <doremylover123@gmail.com>
Subject: Re: [PATCH v12 2/2] win32: close handles of threads that have been joined
Date: Mon, 26 Dec 2022 11:07:25 +0900	[thread overview]
Message-ID: <xmqqilhynciq.fsf@gitster.g> (raw)
In-Reply-To: <fa5cbfa5e0ca86e2143346068c9b99856cdded0c.1671932405.git.gitgitgadget@gmail.com> (Seija Kijin via GitGitGadget's message of "Sun, 25 Dec 2022 01:40:05 +0000")

"Seija Kijin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> diff --git a/compat/win32/pthread.c b/compat/win32/pthread.c
> index 65e15a560d5..83e088dff0a 100644
> --- a/compat/win32/pthread.c
> +++ b/compat/win32/pthread.c
> @@ -41,10 +41,13 @@ int win32_pthread_join(pthread_t *thread, void **value_ptr)
>  	case WAIT_OBJECT_0:
>  		if (value_ptr)
>  			*value_ptr = thread->arg;
> +		CloseHandle(thread->handle);
>  		return 0;
>  	case WAIT_ABANDONED:
> +		CloseHandle(thread->handle);
>  		return EINVAL;
>  	default:
> +		/* the wait failed, so do not detach */
>  		return err_win_to_posix(GetLastError());
>  	}
>  }

This matches what got an Ack from J6t in v7, so I'll queue with
Acked-by: added.  Thanks.