From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8177CC433EF
	for <git@archiver.kernel.org>; Fri,  8 Oct 2021 20:50:11 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 5EAEE60EFF
	for <git@archiver.kernel.org>; Fri,  8 Oct 2021 20:50:11 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S243077AbhJHUwG (ORCPT <rfc822;git@archiver.kernel.org>);
        Fri, 8 Oct 2021 16:52:06 -0400
Received: from pb-smtp20.pobox.com ([173.228.157.52]:65154 "EHLO
        pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S243328AbhJHUwF (ORCPT <rfc822;git@vger.kernel.org>);
        Fri, 8 Oct 2021 16:52:05 -0400
Received: from pb-smtp20.pobox.com (unknown [127.0.0.1])
        by pb-smtp20.pobox.com (Postfix) with ESMTP id C810A14C825;
        Fri,  8 Oct 2021 16:50:09 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type:content-transfer-encoding; s=sasl; bh=ES3VVUDkh2a1
        mBZ2bLfgLLBaS3Rvij3Q+Uqp29wjqjY=; b=ne15Q4Dr5CWLWqw+HzaGT4y90lI6
        lv+n8sHCDq2nO/yFbMQ+tyg3wrCr2YiKcr2+oH8/mLNu3XqD97idBW+BN7I0hJDU
        50Wvju52xbHKBvrq3xVaSCRZS8lusBY57Zz5Fc7UZLMBYkkKVUvuQjxki9Qys6SI
        rV30mHxpn634oHU=
Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1])
        by pb-smtp20.pobox.com (Postfix) with ESMTP id C188B14C824;
        Fri,  8 Oct 2021 16:50:09 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [104.133.2.91])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp20.pobox.com (Postfix) with ESMTPSA id BD51114C81E;
        Fri,  8 Oct 2021 16:50:06 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Jeff King <peff@peff.net>
Cc:     =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason <avarab@gmail.com>,
        git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: ab/fsck-unexpected-type (and "cat-file replace handling and
 optimization")
References: <xmqqo884tkxd.fsf@gitster.g> <87bl43jit5.fsf@evledraar.gmail.com>
        <YVzLRSa9/vUWJPL0@coredump.intra.peff.net>
        <xmqq8rz4pldt.fsf@gitster.g>
        <YV+sLmlWufC5ullA@coredump.intra.peff.net>
Date:   Fri, 08 Oct 2021 13:50:05 -0700
In-Reply-To: <YV+sLmlWufC5ullA@coredump.intra.peff.net> (Jeff King's message
        of "Thu, 7 Oct 2021 22:25:50 -0400")
Message-ID: <xmqqily7jl6q.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
X-Pobox-Relay-ID: 51AA704A-2879-11EC-B72B-F327CE9DA9D6-77302942!pb-smtp20.pobox.com
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Jeff King <peff@peff.net> writes:

> In this case I think neither is churn. I needed to clean up the earlier
> part of the test script so that my later tests didn't break, and =C3=86=
var
> touched the same area to cover more cases in those tests.
> ...
> One other possible thing to do during the resolution is combine the
> cleanup of both objects in a single test (since in =C3=86var's series, =
both
> objects are created together).

That is what makes it a churn X-<.

More coverage does not have to be tied to turning a sequence of
tests into a loop, moving things around, etc.  Just adding more of
similar things wouldn't have caused such a clash with a possible
mismerge.

But I need to point out that it is recognised as a churn only when
there is an unfortunate topic that wants to touch the overlapping
area at the same time.  If there isn't, such a change would be seen
as a valuable preliminary clean-up ;-)

So, of course, it depends on luck.