All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] difftool.c: mark a file-local symbol with static
Date: Wed, 30 Nov 2016 15:46:39 -0800	[thread overview]
Message-ID: <xmqqinr4bkf4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161130231848.v5ge6otytim2t6d2@sigill.intra.peff.net> (Jeff King's message of "Wed, 30 Nov 2016 18:18:48 -0500")

Jeff King <peff@peff.net> writes:

> I forgot, we ended up reversing course later and silencing them:
>
>   http://public-inbox.org/git/20140505052117.GC6569@sigill.intra.peff.net/
>
> By the rationale of that conversation, we should be doing:
>
>   warning("%s", "");
>
> here.

I forgot too.  Thanks for digging up that thread.


  reply	other threads:[~2016-11-30 23:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 17:36 [PATCH] difftool.c: mark a file-local symbol with static Ramsay Jones
2016-11-30 11:07 ` Johannes Schindelin
2016-11-30 19:57   ` Ramsay Jones
2016-11-30 20:40     ` Junio C Hamano
2016-11-30 21:25       ` Jeff King
2016-11-30 22:37         ` Ramsay Jones
2016-11-30 23:18           ` Jeff King
2016-11-30 23:46             ` Junio C Hamano [this message]
2016-12-01  1:18               ` Ramsay Jones
2016-12-01  4:02                 ` Jeff King
2016-12-01 18:20                   ` Junio C Hamano
2016-12-01 18:50                     ` Jeff King
2017-01-22  5:26                       ` David Aguilar
2017-01-24 14:23                         ` Jeff King
2017-01-24 21:52                           ` Junio C Hamano
2017-01-24 23:05                             ` Jeff King
2017-01-25 10:36                               ` Fixing the warning about warning(""); was: " Johannes Schindelin
2017-01-25 18:35                                 ` Jeff King
2017-01-25 21:28                                   ` Junio C Hamano
2017-01-25 22:01                                     ` Jeff King
2017-01-26  6:39                                       ` Johannes Sixt
2017-01-26 11:37                                         ` Johannes Schindelin
2017-01-26 14:35                                           ` Jeff King
2017-01-26 14:32                                         ` Jeff King
2017-01-26 18:26                                           ` Junio C Hamano
2017-01-26 11:16                                   ` Johannes Schindelin
2017-01-26 14:39                                     ` Jeff King
2017-01-26 14:49                                       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqinr4bkf4.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.