Re: [PATCH 3/5] index-pack: correct "len" type in unpack_data()

From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
	Git Mailing List <git@vger.kernel.org>,
	Christoph Michelbach <michelbach94@gmail.com>
Subject: Re: [PATCH 3/5] index-pack: correct "len" type in unpack_data()
Date: Wed, 06 Jul 2016 09:08:59 -0700	[thread overview]
Message-ID: <xmqqinwiu4tg.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqmvluu50w.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Wed, 06 Jul 2016 09:04:31 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Duy Nguyen <pclouds@gmail.com> writes:
>
>> What can I say, gettext is smart. In gc.c we already have this
>>
>> die(_("gc is already running on machine '%s' pid %"PRIuMAX" (use
>> --force if not)"), name, (uintmax_t)pid);
>>
>> and vi.po shows
>>
>> #: builtin/gc.c:397
>> #, c-format
>> msgid ""
>> "gc is already running on machine '%s' pid %<PRIuMAX> (use --force if not)"
>
> And translators are expcted to keep "%<PRIuMAX>" in their translated
> .po files, and whatever translates .po into .mo knows what
> %<PRIuMAX> should be mapped to?
>
> That is surprising.

gettext.info answered me ;-)

    The ‘gettext’ tools and library have special support for these
    ‘<inttypes.h>’ macros.  You can therefore simply write

         printf (gettext ("The amount is %0" PRId64 "\n"), number);

    The PO file will contain the string "The amount is %0<PRId64>\n".  The
    translators will provide a translation containing "%0<PRId64>" as well,
    and at runtime the ‘gettext’ function’s result will contain the
    appropriate constant string, "d" or "ld" or "lld".

       This works only for the predefined ‘<inttypes.h>’ macro...

Nice.