Re: [PATCH v9 2/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875

From: Junio C Hamano <gitster@pobox.com>
To: Max Kirillov <max@max630.net>
Cc: "Duy Nguyen" <pclouds@gmail.com>,
	"SZEDER Gábor" <szeder.dev@gmail.com>,
	"Torsten Bögershausen" <tboegi@web.de>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Jeff King" <peff@peff.net>,
	manschwetus@cs-software-gmbh.de,
	"Chris Packham" <judge.packham@gmail.com>,
	"Konstantin Khomoutov" <kostix+git@007spb.ru>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH v9 2/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875
Date: Sat, 04 Aug 2018 10:20:28 -0700	[thread overview]
Message-ID: <xmqqk1p6rqub.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180804112814.GA2060@jessie.local> (Max Kirillov's message of "Sat, 4 Aug 2018 14:28:14 +0300")

Max Kirillov <max@max630.net> writes:

> On Sat, Aug 04, 2018 at 08:34:08AM +0200, Duy Nguyen wrote:
>> On Fri, Jul 27, 2018 at 5:50 AM Max Kirillov <max@max630.net> wrote:
>>> +       if (max_request_buffer < req_len) {
>>> +               die("request was larger than our maximum size (%lu): "
>>> +                   "%" PRIuMAX "; try setting GIT_HTTP_MAX_REQUEST_BUFFER",
>>> +                   max_request_buffer, (uintmax_t)req_len);
>> 
>> Please mark these strings for translation with _().
>
> It has been discussed in [1]. Since it is not a local user
> facing part, probably should not be translated.
>
> [1] https://public-inbox.org/git/20180610150727.GE27650@jessie.local/

I'd support that design decision, FWIW.