From: Junio C Hamano <gitster@pobox.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
git@vger.kernel.org, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v7] read-cache: force_verify_index_checksum
Date: Mon, 24 Apr 2017 19:10:53 -0700 [thread overview]
Message-ID: <xmqqk269xmmq.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <8bde0b54-c0f6-364d-1f08-ce5207eb6c86@jeffhostetler.com> (Jeff Hostetler's message of "Mon, 24 Apr 2017 14:39:27 -0400")
Jeff Hostetler <git@jeffhostetler.com> writes:
>>> +test_expect_success 'detect corrupt index file in fsck' '
>>> + cp .git/index .git/index.backup &&
>>> + test_when_finished "mv .git/index.backup .git/index" &&
>>> + echo zzzzzzzz >zzzzzzzz &&
>>> + git add zzzzzzzz &&
>>> + sed -e "s/zzzzzzzz/yyyyyyyy/" .git/index >.git/index.yyy &&
>>
>> sed on a binary file? Sooner or later we are going to run into
>> portability issues.
>
> In v5 of this patch series I used "perl" and it was suggested that I
> use "sed" instead.
> It doesn't matter to me which we use. My testing showed that it was
> safe, but that
> was only Linux.
>
> Does the mailing list have a preference for this ?
Instead of munging pathnames z* to y*, I'd prefer to see the actual
checksum bytes at the end replaced in the index file. After all
that is what this test really cares about, and it ensures that the
failure detected is due to checksum mismatch.
>>> + mv .git/index.yyy .git/index &&
>>> + # Confirm that fsck detects invalid checksum
>>> + test_must_fail git fsck --cache &&
>>
>> You should ensure that this failure is really because of an invalid
>> checksum. The failure could also be due to an extra LF at the end
>> that sed inserted, no?
>
> I suppose we could, but I'm tempted to wait on that for now.
>
> Jeff
next prev parent reply other threads:[~2017-04-25 2:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 20:32 [PATCH v7] read-cache: call verify_hdr() in a background thread git
2017-04-14 20:32 ` [PATCH v7] read-cache: force_verify_index_checksum git
2017-04-24 17:26 ` Johannes Sixt
2017-04-24 18:39 ` Jeff Hostetler
2017-04-25 2:10 ` Junio C Hamano [this message]
2017-04-25 21:04 ` Johannes Schindelin
2017-04-26 3:25 ` Junio C Hamano
2017-05-08 9:45 ` Christian Couder
2017-05-08 16:50 ` Jeff Hostetler
2017-05-08 20:03 ` Christian Couder
2017-05-08 20:18 ` Jeff Hostetler
2017-05-09 2:11 ` Junio C Hamano
2017-05-09 5:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk269xmmq.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.