From: Junio C Hamano <gitster@pobox.com>
To: Vladimir Panteleev <git@thecybershadow.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 0/5] show-ref: Allow -d, --head to work with --verify
Date: Mon, 23 Jan 2017 12:03:56 -0800 [thread overview]
Message-ID: <xmqqk29lr1ar.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170123180059.4288-1-git@thecybershadow.net> (Vladimir Panteleev's message of "Mon, 23 Jan 2017 18:00:54 +0000")
Vladimir Panteleev <git@thecybershadow.net> writes:
> Third iteration, according to Junio's comments. This time we keep
> show_ref and show_one separate, accept HEAD with --verify even without
> --head, and add tests for dangling ref validation with --verify.
I am no longer a neutral judge but to me the resulting code looks a
lot more naturally structured than the original.
Thanks. Will queue.
prev parent reply other threads:[~2017-01-23 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 18:00 [PATCH v3 0/5] show-ref: Allow -d, --head to work with --verify Vladimir Panteleev
2017-01-23 18:00 ` [PATCH v3 1/5] show-ref: Accept HEAD " Vladimir Panteleev
2017-01-23 18:00 ` [PATCH v3 2/5] show-ref: Allow -d to work " Vladimir Panteleev
2017-01-23 18:00 ` [PATCH v3 3/5] show-ref: Move --quiet handling into show_one Vladimir Panteleev
2017-01-23 18:00 ` [PATCH v3 4/5] show-ref: Detect dangling refs under --verify as well Vladimir Panteleev
2017-01-24 2:48 ` Junio C Hamano
2017-01-23 18:00 ` [PATCH v3 5/5] show-ref: Remove dead `if (verify)' check Vladimir Panteleev
2017-01-23 20:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk29lr1ar.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@thecybershadow.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.