All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Turner <dturner@twopensource.com>
Cc: git@vger.kernel.org, David Turner <dturner@twitter.com>
Subject: Re: [PATCH v5 3/3] cat-file: add --follow-symlinks to --batch
Date: Tue, 12 May 2015 11:43:09 -0700	[thread overview]
Message-ID: <xmqqk2wdzlfm.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1431455779.16652.20.camel@ubuntu> (David Turner's message of "Tue, 12 May 2015 14:36:19 -0400")

David Turner <dturner@twopensource.com> writes:

>> We need to also say something about the "missing" vs "loop" case, if
>> we choose to leave that part broken.  I'd rather see it fixed, but
>> that is not a very strong preference.
>
> Will add an example.

I do not think we need an example.  By "also say", I meant in
addition to "This and that does not currently work", we also need to
say that loops do not work well.  In other words, it is enough to
just mention that it is a current limitation (or a bug, whichever we
choose to call) that loops are reported as missing.

Thanks.

  reply	other threads:[~2015-05-12 18:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 22:50 [PATCH v5 0/3] cat-file --follow-symlinks dturner
2015-05-11 22:50 ` [PATCH v5 1/3] tree-walk: learn get_tree_entry_follow_symlinks dturner
2015-05-12 17:29   ` Johannes Sixt
2015-05-11 22:50 ` [PATCH v5 2/3] sha1_name: get_sha1_with_context learns to follow symlinks dturner
2015-05-11 22:50 ` [PATCH v5 3/3] cat-file: add --follow-symlinks to --batch dturner
2015-05-12 17:34   ` Johannes Sixt
2015-05-12 18:07   ` Junio C Hamano
2015-05-12 18:36     ` David Turner
2015-05-12 18:43       ` Junio C Hamano [this message]
2015-05-12 18:55         ` David Turner
2015-05-12 20:00           ` Junio C Hamano
2015-05-12 20:22             ` Junio C Hamano
2015-05-12 22:36               ` David Turner
2015-05-12 23:02                 ` Junio C Hamano
2015-05-12 23:06                   ` Junio C Hamano
2015-05-12 20:07       ` Junio C Hamano
2015-05-12 21:37         ` David Turner
2015-05-12 21:42           ` Junio C Hamano
2015-05-12 21:53             ` David Turner
2015-05-14 20:06       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk2wdzlfm.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=dturner@twitter.com \
    --cc=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.