From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC01C433FE for ; Tue, 16 Nov 2021 19:04:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 103C76321B for ; Tue, 16 Nov 2021 19:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239742AbhKPTHQ (ORCPT ); Tue, 16 Nov 2021 14:07:16 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:63552 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239717AbhKPTHO (ORCPT ); Tue, 16 Nov 2021 14:07:14 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id D2F16EC89E; Tue, 16 Nov 2021 14:04:16 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=1zrxo3NGuL47 7POu9Nmgbookg/U+OmjBWo5iZ1bPz9Y=; b=uByGEeG32roPwGVaeU0SVc/EWS8c WOUdEG5sNfmUKRyXI+8ySZM9oxgvMTNMUjDvzUoaNySNv4RA09AOx7+tOJcqu44L mLFFyL686YCWT5EwdligTEMUnK5aSfieuCE6eYdK+5n5LtkQ6ZWA93fkAZBFRZpc 6Vb1FSGGUshvm3k= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id CA081EC89C; Tue, 16 Nov 2021 14:04:16 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 325CDEC89A; Tue, 16 Nov 2021 14:04:16 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org Subject: Re: [PATCH] t0006: date_mode can leak .strftime_fmt member References: <211104.86mtmki5ol.gmgdl@evledraar.gmail.com> Date: Tue, 16 Nov 2021 11:04:15 -0800 In-Reply-To: (=?utf-8?B?IsOGdmFyCUFybmZqw7Zyw7A=?= Bjarmason"'s message of "Tue, 16 Nov 2021 19:31:12 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: FE8AFE24-470F-11EC-B2D6-62A2C8D8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > As there is no date_mode_release() API function, and given the > set of current callers it probably is not worth adding one, let's > release the .strftime_fmt member that is obtained from strdup() > before the caller of show_date() is done with it. I do not know what the last line exactly wants to say. Perhaps the original author meant "after", not "before"? ;-)