All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Hamza Mahfooz <someguy@effective-light.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v11 3/3] grep: fix an edge case concerning ascii patterns and UTF-8 data
Date: Fri, 08 Oct 2021 23:44:14 -0700	[thread overview]
Message-ID: <xmqqlf32g0jl.fsf@gitster.g> (raw)
In-Reply-To: 20211007203148.23888-3-someguy@effective-light.com

Hamza Mahfooz <someguy@effective-light.com> writes:

> diff --git a/t/t7812-grep-icase-non-ascii.sh b/t/t7812-grep-icase-non-ascii.sh
> index e5d1e4ea68..42323b31c0 100755
> --- a/t/t7812-grep-icase-non-ascii.sh
> +++ b/t/t7812-grep-icase-non-ascii.sh
> @@ -53,6 +53,54 @@ test_expect_success REGEX_LOCALE 'pickaxe -i on non-ascii' '
> ...
> +	git add file5 &&
> +	export GIT_COMMITTER_NAME="Ç O Mîtter" &&
> +	export GIT_COMMITTER_EMAIL="committer@example.com" &&

These lines are flagged as an error by test-lint; I've queued this
on top to make today's integration result to pass our tests.

Thanks.


 t/t7812-grep-icase-non-ascii.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t7812-grep-icase-non-ascii.sh b/t/t7812-grep-icase-non-ascii.sh
index 42323b31c0..313d4894ad 100755
--- a/t/t7812-grep-icase-non-ascii.sh
+++ b/t/t7812-grep-icase-non-ascii.sh
@@ -72,8 +72,8 @@ test_expect_success GETTEXT_LOCALE,PCRE 'log --committer with an ascii pattern o
 	EOF
 	test_write_lines "fifth" >file5 &&
 	git add file5 &&
-	export GIT_COMMITTER_NAME="Ç O Mîtter" &&
-	export GIT_COMMITTER_EMAIL="committer@example.com" &&
+	GIT_COMMITTER_NAME="Ç O Mîtter" GIT_COMMITTER_EMAIL="committer@example.com" &&
+	export GIT_COMMITTER_NAME GIT_COMMITTER_EMAIL &&
 	git -c i18n.commitEncoding=latin1 commit -m thïrd &&
 	git -c i18n.logOutputEncoding=latin1 log -1 --pretty=fuller --color=always --perl-regexp --committer=" O.*" >log &&
 	grep Commit: log >actual.raw &&
-- 
2.33.0-960-g8d902839aa


  parent reply	other threads:[~2021-10-09  6:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 20:31 [PATCH v11 1/3] grep: refactor next_match() and match_one_pattern() for external use Hamza Mahfooz
2021-10-07 20:31 ` [PATCH v11 2/3] pretty: colorize pattern matches in commit messages Hamza Mahfooz
2021-10-07 20:31 ` [PATCH v11 3/3] grep: fix an edge case concerning ascii patterns and UTF-8 data Hamza Mahfooz
2021-10-08 21:26   ` Junio C Hamano
2021-10-09  6:44   ` Junio C Hamano [this message]
2021-10-09 15:52     ` Hamza Mahfooz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlf32g0jl.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=someguy@effective-light.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.