All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matheus Tavares <matheus.bernardino@usp.br>
Cc: asottile@umich.edu, git@vger.kernel.org
Subject: Re: git git<tab> completes non-existent command `git gitk`
Date: Sun, 24 May 2020 17:27:52 -0700	[thread overview]
Message-ID: <xmqqlflgq2nr.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200524213808.24849-1-matheus.bernardino@usp.br> (Matheus Tavares's message of "Sun, 24 May 2020 18:38:08 -0300")

Matheus Tavares <matheus.bernardino@usp.br> writes:

> This should solve the problem, althought it's admittedly not very elegant...
> Nevertheless, I'd be happy to send a complete patch if folks are happy with the
> workaround.

Please don't.

> In the meantime, you could use:
>
> 	git config completion.commands -gitk
>
> To locally remove the completion for "gitk".

I think an equivalent of this in-core would be the way to go.  I
wonder if there are any commands other than gitk that cannot be
invoked as a subcommand of "git" potty.

t/t9902-completion.sh would be a good place to test this.

  reply	other threads:[~2020-05-25  0:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-23 22:25 git git<tab> completes non-existent command `git gitk` Anthony Sottile
2020-05-24 21:38 ` Matheus Tavares
2020-05-25  0:27   ` Junio C Hamano [this message]
2020-05-25  1:53     ` Matheus Tavares Bernardino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlflgq2nr.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=asottile@umich.edu \
    --cc=git@vger.kernel.org \
    --cc=matheus.bernardino@usp.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.