All of
 help / color / mirror / Atom feed
From: Junio C Hamano <>
To: "Elijah Newren" <>,
	"Ævar Arnfjörð Bjarmason" <>
Cc: Git Mailing List <>
Subject: Re: What's cooking in git.git (Jan 2022, #03; Thu, 13)
Date: Fri, 14 Jan 2022 11:47:26 -0800	[thread overview]
Message-ID: <xmqqmtjyaylt.fsf@gitster.g> (raw)
In-Reply-To: <> (Elijah Newren's message of "Fri, 14 Jan 2022 08:27:54 -0800")

Elijah Newren <> writes:

> It's apparently the latter, because there have been no test script
> changes in the relevant tests.
>> Somebody with too much time on their hand should go in and check to
>> help, before CI testing on 'seen' becomes useful again.
> This "fixes" seen:
> I briefly looked at a couple leak traces and thought they looked ref
> related, but I don't have time to go hunt down memory leaks right now.
> I figure this thread has reported them, so let's just get "seen" back
> to green.

If it were "we added a use of known-to-leak command in an otherwise
clean test, without adding a new leak", I would wholeheartedly
support such a change, but if it is the other way around, it may
make sense to leave it broken as an incentive for people who care
about leaks to go in and fix them up.

If we toggle it off any time leak-checker CI job starts complaining
on a test script, the leak-checker CI job serves no useful purpose,

An obvious alternative, based on the same attitude, is to rip out
the whole fragile leak-checker thing from the CI.  I've mentioned
an ideal alternative (disregarding feasibility) already elsewhere
so I won't repeat it.


  reply	other threads:[~2022-01-14 19:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14  0:48 What's cooking in git.git (Jan 2022, #03; Thu, 13) Junio C Hamano
2022-01-14  4:18 ` Junio C Hamano
2022-01-14 16:27   ` Elijah Newren
2022-01-14 19:47     ` Junio C Hamano [this message]
2022-01-14 21:49       ` Elijah Newren
2022-01-14 22:03         ` Junio C Hamano
2022-01-14 22:18           ` Junio C Hamano
2022-01-14 18:12   ` Ævar Arnfjörð Bjarmason
2022-01-17  7:18     ` Patrick Steinhardt
2022-01-14 15:44 ` Mistakes in the stalled category? (Was: Re: What's cooking in git.git (Jan 2022, #03; Thu, 13)) Elijah Newren
2022-01-14 23:32   ` Mistakes in the stalled category? Junio C Hamano
2022-01-14 23:49   ` Junio C Hamano
2022-01-15 19:38     ` Junio C Hamano
2022-01-18 16:11       ` Derrick Stolee
2022-01-14 15:54 ` en/present-despite-skipped & en/remerge-diff (Was: Re: What's cooking in git.git (Jan 2022, #03; Thu, 13)) Elijah Newren
2022-01-14 19:39 ` tb/midx-bitmap-corruption-fix (was: " Taylor Blau
2022-01-15 16:45 ` What's cooking in git.git (Jan 2022, #03; Thu, 13) David Aguilar
2022-01-15 19:15   ` Junio C Hamano
2022-01-16  2:15     ` David Aguilar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmtjyaylt.fsf@gitster.g \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.