From: Junio C Hamano <gitster@pobox.com>
To: Chinmoy Chakraborty <chinmoy12c@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v4] cache-tree.c: remove implicit dependency on the_repository
Date: Thu, 08 Apr 2021 06:23:05 -0700 [thread overview]
Message-ID: <xmqqmtu8vrk6.fsf@gitster.g> (raw)
In-Reply-To: 0df415b7-73b7-6e72-1885-3ca606acf8fd@gmail.com
Chinmoy Chakraborty <chinmoy12c@gmail.com> writes:
> Is it safe to make this assumption?
It was the question I asked, and I didn't see a reason to believe it
is safe.
> I mean to be completely sure of this, one would have to track back
> to all the callers.
Yes. If we audit the callers to make sure istate->repo always
points at the right repository, add missing assignment to
istate->repo as necessary, and add
if (!istate->repo)
BUG("caller of cache_tree_udpate() did not fill istate->repo");
then that would be an improvement. But...
> Should a check like:
>
> if(!istate->repo)
>
> istate->repo = the_repository;
>
> be required?
... if we add such an "if the caller did not set istate->repo,
assume the_repository" code, then the resulting code explicitly
assumes that the istate the caller passed to us without setting
istate->repo belongs to the default repository.
I do not quite see the point of such a change---it is not all that
better than "implicit dependency on the_repository" the patch tries
to address, is it?
prev parent reply other threads:[~2021-04-08 13:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 19:48 [PATCH] cache-tree.c: remove implicit dependency on the_repository Chinmoy via GitGitGadget
2021-03-25 20:31 ` Derrick Stolee
2021-03-26 6:49 ` Chinmoy Chakraborty
2021-03-26 7:54 ` Chinmoy Chakraborty
2021-03-26 15:35 ` [PATCH v2] " Chinmoy via GitGitGadget
2021-04-03 15:57 ` [PATCH v3] " Chinmoy via GitGitGadget
2021-04-04 1:49 ` Junio C Hamano
2021-04-04 5:11 ` Chinmoy Chakraborty
2021-04-04 5:36 ` Junio C Hamano
2021-04-04 5:18 ` Chinmoy Chakraborty
2021-04-04 6:09 ` Junio C Hamano
2021-04-05 13:08 ` Derrick Stolee
2021-04-05 17:48 ` Junio C Hamano
2021-04-07 6:54 ` [PATCH v4] " Chinmoy via GitGitGadget
2021-04-07 23:03 ` Junio C Hamano
2021-04-08 3:56 ` Chinmoy Chakraborty
2021-04-08 13:23 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmtu8vrk6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chinmoy12c@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.