All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Neeraj Singh <nksingh85@gmail.com>
Cc: Adam Dinwoodie <adam@dinwoodie.org>,
	git@vger.kernel.org, Neeraj Singh <neerajsi@microsoft.com>
Subject: Re: [PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition
Date: Wed, 06 Apr 2022 09:35:17 -0700	[thread overview]
Message-ID: <xmqqo81eyxtm.fsf@gitster.g> (raw)
In-Reply-To: <20220405153159.GA22458@neerajsi-x1.localdomain> (Neeraj Singh's message of "Tue, 5 Apr 2022 08:31:59 -0700")

Neeraj Singh <nksingh85@gmail.com> writes:

> On Tue, Apr 05, 2022 at 11:00:20AM +0100, Adam Dinwoodie wrote:
>> If sync_file_range is not available when building the configure script,
>> there is a cosmetic bug when running that script reporting
>> "HAVE_SYNC_FILE_RANGE: command not found".  Remove that error message by
>> defining HAVE_SYNC_FILE_RANGE to an empty string, rather than generating
>> a script where that appears as a bare command.
>> 
>> Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
>> ---
>>  configure.ac | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/configure.ac b/configure.ac
>> index 6bd6bef1c4..316a31d231 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1087,7 +1087,7 @@ GIT_CONF_SUBST([HAVE_CLOCK_MONOTONIC])
>>  # Define HAVE_SYNC_FILE_RANGE=YesPlease if sync_file_range is available.
>>  GIT_CHECK_FUNC(sync_file_range,
>>  	[HAVE_SYNC_FILE_RANGE=YesPlease],
>> -	[HAVE_SYNC_FILE_RANGE])
>> +	[HAVE_SYNC_FILE_RANGE=])
>>  GIT_CONF_SUBST([HAVE_SYNC_FILE_RANGE])
>>  
>>  #
>> -- 
>> 2.35.1
>> 
>
> Thanks for fixing this.  Looks good to me.

Thanks, both.

Will apply.

      reply	other threads:[~2022-04-06 18:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 10:00 [PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition Adam Dinwoodie
2022-04-05 15:31 ` Neeraj Singh
2022-04-06 16:35   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo81eyxtm.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=adam@dinwoodie.org \
    --cc=git@vger.kernel.org \
    --cc=neerajsi@microsoft.com \
    --cc=nksingh85@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.