Re: What's cooking in git.git (Jul 2021, #03; Tue, 13)

[Junio C Hamano <gitster@pobox.com>]

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Wed, Jul 14, 2021 at 12:30 PM Junio C Hamano <gitster@pobox.com> wrote:
>> Eric Sunshine <sunshine@sunshineco.com> writes:
>> > I think this series is ready and gave my Reviewed-by: here[1]. One of
>> > the new tests contains an unnecessary but harmless `test -f`[2], but
>> > it's such a minor nit that I doubt it's worth demanding a re-roll.
>>
>> I think having "test -f" is the right thing to do, so [2] is
>> probably OK as-is.  test_cmp may want to complain about a possible
>> bug in the test when given a missing file.  [...]
>
> We tried relatively recently to have test_cmp() complain about a
> missing file[1], but both Ævar[2] and Peff[3] ran into problems in
> which tests (presumably) legitimately called test_cmp() on missing
> files, so the suggestion was made to revert the check[4], which is
> indeed what happened[5].

Yes, I know all that, and even with that, having "test -f" is the
right thing to do, so [2] is probably OK as-is.

> [1]: https://lore.kernel.org/git/20200809174209.15466-1-sunshine@sunshineco.com/
> [2]: https://lore.kernel.org/git/20200921104000.2304-15-avarab@gmail.com/
> [3]: https://lore.kernel.org/git/20201016001704.GA2937048@coredump.intra.peff.net/
> [4]: https://lore.kernel.org/git/CAPig+cSU=1GcQuqZab+0Vff_A-JmD59wEc3RMr3wDojpgRYUuw@mail.gmail.com/
> [5]: https://lore.kernel.org/git/xmqqv9f9ao0v.fsf@gitster.c.googlers.com/