From: Junio C Hamano <gitster@pobox.com>
To: Kevin Daudt <me@ikke.info>
Cc: Nikolay Yakimov <root@livid.pp.ru>,
git@vger.kernel.org, Anders Kaseorg <andersk@mit.edu>
Subject: Re: Multiple paths in GIT_EXEC_PATH
Date: Wed, 18 Oct 2017 06:08:10 +0900 [thread overview]
Message-ID: <xmqqo9p5mqit.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171017155625.GE19335@alpha.vpn.ikke.info> (Kevin Daudt's message of "Tue, 17 Oct 2017 17:56:25 +0200")
Kevin Daudt <me@ikke.info> writes:
> The commit that changed what you described is 1073094f3 (git-sh-setup:
> be explicit where to dot-source git-sh-i18n from., 2016-10-29). That
> commit claims there were already scripts that assumed GIT_EXEC_PATH is
> just a single entry. That commit was included in v2.11.
>
> There was also a recent thread[0] about it that discussed this issue,
> where someone stated that indeed treating GIT_EXEC_PATH with the same
> semantics as PATH has been broken for a while, but it seems there are no
> real plans to fix it.
The variable was never meant to have more than one path concatenated
with ':' from day one.
In C code we've used it as a leading directory path to tack a
command name to form a path to give to exec(3), without any
intention to have it a list of paths, which is split at ':'.
sh-setup was doing "PATH=$GIT_EXEC_PATH:$PATH" without rejecting a
value in GIT_EXEC_PATH with a colon in it but that was merely being
lazy and made it "work" by accident.
next prev parent reply other threads:[~2017-10-17 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 15:21 Multiple paths in GIT_EXEC_PATH Nikolay Yakimov
2017-10-17 15:56 ` Kevin Daudt
2017-10-17 21:08 ` Junio C Hamano [this message]
2017-10-24 20:12 ` Dennis Kaarsemaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9p5mqit.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=andersk@mit.edu \
--cc=git@vger.kernel.org \
--cc=me@ikke.info \
--cc=root@livid.pp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.