From: Junio C Hamano <gitster@pobox.com>
To: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
Philip Oakley <philipoakley@iee.org>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [RFC] The correct and consistent alternative to quote a command ?
Date: Wed, 02 Aug 2017 08:37:16 -0700 [thread overview]
Message-ID: <xmqqo9rydlqr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1501676577.1957.4.camel@gmail.com> (Kaartic Sivaraam's message of "Wed, 02 Aug 2017 17:52:57 +0530")
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
> On Tue, 2017-08-01 at 10:38 -0700, Stefan Beller wrote:
>> On Tue, Aug 1, 2017 at 8:59 AM, Kaartic Sivaraam wrote:
>> > I assume you mean the consistency in quoting i.e., you're expecting the
>> > patch to use (") instead of (') for quoting. Correct me, if I'm wrong.
>>
>> Actually I did not imply any expectation on the outcome, because I
>> do not know what the consistency end game looks like for this issue.
>>
>> So maybe we'd want to go with the currently most used way?
> On scanning through Documentation/SubmittingPatches, I saw that most of
> the commands were quoted using double quotes and chose to use it for
> this patch. I'm not sure if it's the right one to use.
After reading the patch before seeing the above, I also came to the
conclusion that the above is exactly what you are aiming at, and I
thought that was a reasonable thing to do.
next prev parent reply other threads:[~2017-08-02 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 11:09 [PATCH 1/2] doc: fix small issues in SubmittingPatches Kaartic Sivaraam
2017-07-30 11:09 ` [PATCH 2/2] doc: add another way to identify if a patch has been merged Kaartic Sivaraam
2017-07-30 14:49 ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Philip Oakley
2017-07-30 16:17 ` Kaartic Sivaraam
2017-07-30 16:18 ` Kaartic Sivaraam
2017-07-31 20:23 ` Stefan Beller
2017-07-31 20:34 ` Junio C Hamano
2017-08-01 15:59 ` Kaartic Sivaraam
2017-08-01 17:38 ` Stefan Beller
2017-08-02 12:22 ` [RFC] The correct and consistent alternative to quote a command ? Kaartic Sivaraam
2017-08-02 15:37 ` Junio C Hamano [this message]
2017-08-02 17:32 ` Stefan Beller
2017-08-03 15:35 ` Kaartic Sivaraam
2017-08-01 16:05 ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Kaartic Sivaraam
2017-08-01 16:05 ` [PATCH 2/2] doc: add another way to identify if a patch has been merged Kaartic Sivaraam
2017-08-01 17:46 ` Stefan Beller
2017-08-02 12:32 ` Kaartic Sivaraam
2017-08-02 16:01 ` Junio C Hamano
2017-08-02 16:28 ` Junio C Hamano
2017-08-02 17:58 ` Stefan Beller
2017-08-07 14:34 ` Kaartic Sivaraam
2017-08-07 14:33 ` Kaartic Sivaraam
2017-08-01 21:04 ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9rydlqr.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kaarticsivaraam91196@gmail.com \
--cc=philipoakley@iee.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.