From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: David Turner <dturner@twosigma.com>, git@vger.kernel.org
Subject: Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values
Date: Sat, 01 Apr 2017 11:09:56 -0700 [thread overview]
Message-ID: <xmqqo9wguhhn.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170401060116.b2v7tyoi7fcxwbvo@sigill.intra.peff.net> (Jeff King's message of "Sat, 1 Apr 2017 02:01:16 -0400")
Jeff King <peff@peff.net> writes:
> On Fri, Mar 31, 2017 at 01:26:31PM -0400, David Turner wrote:
>
>> Unfortunately, in order to push some large repos, the http postbuffer
>> must sometimes exceed two gigabytes. On a 64-bit system, this is OK:
>> we just malloc a larger buffer.
>
> I'm still not sure why a 2GB post-buffer is necessary. It sounds like
> something is broken in your setup. Large pushes should be sent chunked.
>
> I know broken setups are a fact of life, but this feels like a really
> hacky work-around.
Yeah, I tend to share that "Huh? We do not want to do this, but what
forces us to?" puzzlement.
Tentatively demoted to 'pu' (out of 'jch'--candidates to go to 'next').
next prev parent reply other threads:[~2017-04-01 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 17:26 [PATCH v3] http.postbuffer: allow full range of ssize_t values David Turner
2017-03-31 19:51 ` Junio C Hamano
2017-04-01 6:01 ` Jeff King
2017-04-01 18:09 ` Junio C Hamano [this message]
2017-04-03 17:03 ` David Turner
2017-04-04 2:01 ` Jeff King
2017-04-04 18:42 ` David Turner
2017-04-04 20:40 ` Jeff King
2017-04-06 17:24 ` Christian Couder
2017-04-07 4:48 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9wguhhn.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.