All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: <git@vger.kernel.org>
Subject: Re: [Proposed] Externalize man/html ref for quick-install-man and quick-install-html
Date: Tue, 12 Dec 2017 15:40:29 -0800	[thread overview]
Message-ID: <xmqqpo7jy0pe.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <004b01d373a0$3ec759d0$bc560d70$@nexbridge.com> (Randall S. Becker's message of "Tue, 12 Dec 2017 18:23:35 -0500")

"Randall S. Becker" <rsbecker@nexbridge.com> writes:

> Yes, needed. The lines wrapped om Documentation/Makefile - each
> change in quick-install-man/html should be exactly one line:
>
> quick-install-man: require-manrepo
> -	'$(SHELL_PATH_SQ)' ./install-doc-quick.sh $(MAN_REPO) $(DESTDIR)$(mandir)
> +	'$(SHELL_PATH_SQ)' ./install-doc-quick.sh $(MAN_REPO) $(DESTDIR)$(mandir) $(GIT_MAN_REF)
>  
> And here
>
>  quick-install-html: require-htmlrepo
> -	'$(SHELL_PATH_SQ)' ./install-doc-quick.sh $(HTML_REPO) $(DESTDIR)$(htmldir)
> +	'$(SHELL_PATH_SQ)' ./install-doc-quick.sh $(HTML_REPO) $(DESTDIR)$(htmldir) $(GIT_MAN_REF)

I somehow have a feeling that you are not even looking at the right
rendition.

To everybody else who did not complain that what I sent was
line-wrapped, the message should be showing like this:

    https://public-inbox.org/git/xmqqtvwvy1rh.fsf@gitster.mtv.corp.google.com/

Perhaps the mail program on your receiving end is mangling what you
got from the mailing list, giving you a line-wrapped version.

It also unfortunately makes me suspect that you didn't actually have
a chance to apply the patch mechanically and make sure it works for
you due to mail mangling at your end X-<.

> And otherwise please consider it signed off.

Will do, thanks.

  reply	other threads:[~2017-12-12 23:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-09 22:07 [Proposed] Externalize man/html ref for quick-install-man and quick-install-html Randall S. Becker
2017-12-11 23:27 ` Junio C Hamano
2017-12-12  0:26   ` Randall S. Becker
2017-12-12 10:50     ` Jacob Keller
2017-12-12 23:17     ` Junio C Hamano
2017-12-12 23:23       ` Randall S. Becker
2017-12-12 23:40         ` Junio C Hamano [this message]
2017-12-12 23:54           ` Randall S. Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpo7jy0pe.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.