From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: "Christian Göttsche" <cgzones@googlemail.com>, git@vger.kernel.org
Subject: Re: [PATCH] setup: avoid unconditional open with write flags
Date: Wed, 07 Dec 2022 08:39:35 +0900 [thread overview]
Message-ID: <xmqqr0xc85l4.fsf@gitster.g> (raw)
In-Reply-To: <f49b915e-46d1-7e53-ae4f-b01c2028b70d@web.de> (=?utf-8?Q?=22R?= =?utf-8?Q?en=C3=A9?= Scharfe"'s message of "Tue, 6 Dec 2022 20:47:09 +0100")
René Scharfe <l.s.r@web.de> writes:
> Can opening /dev/null (or NUL on Windows) multiple times instead of dup'ing
> cause issues? Can we e.g. lock ourselves out?
258e93a1 (daemon: if one of the standard fds is missing open it to
/dev/null, 2006-07-13) unfortunately does not explain why it was
done this way.
Given that "command </dev/null >/dev/null 2>/dev/null" should work fine,
I suspect that the "once we open a throw-away descriptor, instead of
opening the same file again, dup the fd and reuse" was done not for
correctness but for performance, under the assumption that open() is
more expensive?
prev parent reply other threads:[~2022-12-06 23:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 19:00 [PATCH] setup: avoid unconditional open with write flags Christian Göttsche
2022-12-05 22:13 ` brian m. carlson
2022-12-06 1:38 ` Jeff King
2022-12-06 16:15 ` Christian Göttsche
2022-12-05 22:59 ` Taylor Blau
2022-12-06 0:10 ` Junio C Hamano
2022-12-06 0:31 ` Taylor Blau
2022-12-06 0:40 ` Junio C Hamano
2022-12-06 19:47 ` René Scharfe
2022-12-06 23:39 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr0xc85l4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=cgzones@googlemail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.