From: Junio C Hamano <gitster@pobox.com>
To: Alex Henrie <alexhenrie24@gmail.com>
Cc: git@vger.kernel.org, liu.denton@gmail.com
Subject: Re: [PATCH v2] rebase: add a config option for --no-fork-point
Date: Mon, 22 Feb 2021 15:39:07 -0800 [thread overview]
Message-ID: <xmqqr1l765b8.fsf@gitster.g> (raw)
In-Reply-To: <20210220051025.4672-1-alexhenrie24@gmail.com> (Alex Henrie's message of "Fri, 19 Feb 2021 22:10:25 -0700")
Alex Henrie <alexhenrie24@gmail.com> writes:
> +test_expect_success 'rebase.forkPoint set to false' '
> + test_config rebase.forkPoint false &&
> + test_rebase "G F C E D B A"
> +'
> +
> +test_expect_success 'rebase.forkPoint set to false and then to true' '
> + test_config_global rebase.forkPoint false &&
> + test_config rebase.forkPoint true &&
> + test_rebase "G F E D B A"
> +'
> +
> +test_expect_success 'rebase.forkPoint set to false and command line says --fork-point' '
> + test_config rebase.forkPoint false &&
> + test_rebase "G F E D B A" --fork-point
> +'
> +
> +test_expect_success 'rebase.forkPoint set to true and command line says --no-fork-point' '
> + test_config rebase.forkPoint true &&
> + test_rebase "G F C E D B A" --no-fork-point
> +'
All of these four look dubious, as test_rebase is defined to run its
own test_expect_success in it.
next prev parent reply other threads:[~2021-02-22 23:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 5:10 [PATCH v2] rebase: add a config option for --no-fork-point Alex Henrie
2021-02-22 23:39 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-21 4:13 Alex Henrie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1l765b8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.