From: Junio C Hamano <gitster@pobox.com>
To: Tejun Heo <tj@kernel.org>
Cc: git@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2] name_rev: add support for --cherry-picks
Date: Thu, 26 Jul 2018 12:01:34 -0700 [thread overview]
Message-ID: <xmqqr2jpq0s1.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180726153714.GX1934745@devbig577.frc2.facebook.com> (Tejun Heo's message of "Thu, 26 Jul 2018 08:37:14 -0700")
Tejun Heo <tj@kernel.org> writes:
> I should have explained the use case better.
No, you did not need to. I was not saying the feature is not useful.
I was only saying that "explain where in the history X sits" command
(i.e. "name-rev X" and "describe X") did not look like a good place
to have that feature.
> Upstream, it's v4.17-rc1
> Backported and released through v4.16-prod-r2
> Also backported to v4.16-prod-r1 (cuz the fix happened while r1 was going through rc's)
>
> So, it extends the description of how the original commit is released
> (or given name) so that releases through cherry-picks are also
> included.
Perhaps. I am not yet 100% convinced, but having a less hard time
trying to convince myself now ;-)
Thanks.
next prev parent reply other threads:[~2018-07-26 19:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 12:13 [PATCH] name_rev: add support for --cherry-picks Tejun Heo
2018-07-26 14:39 ` [PATCH v2] " Tejun Heo
2018-07-26 15:12 ` Junio C Hamano
2018-07-26 15:37 ` Tejun Heo
2018-07-26 19:01 ` Junio C Hamano [this message]
2018-07-27 8:40 ` Jeff King
2018-07-27 14:47 ` Tejun Heo
2018-07-27 15:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2jpq0s1.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.