Re: [GSoC][PATCH v5 0/3] rebase -i: rewrite reflog operations in C

From: Junio C Hamano <gitster@pobox.com>
To: Alban Gruin <alban.gruin@gmail.com>
Cc: git@vger.kernel.org, Stefan Beller <sbeller@google.com>,
	Christian Couder <christian.couder@gmail.com>,
	Pratik Karki <predatoramigo@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	phillip.wood@dunelm.org.uk
Subject: Re: [GSoC][PATCH v5 0/3] rebase -i: rewrite reflog operations in C
Date: Fri, 29 Jun 2018 09:55:34 -0700	[thread overview]
Message-ID: <xmqqr2kpv8ft.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180629151435.31868-1-alban.gruin@gmail.com> (Alban Gruin's message of "Fri, 29 Jun 2018 17:14:32 +0200")

Alban Gruin <alban.gruin@gmail.com> writes:

> This patch series rewrites the reflog operations from shell to C.  This
> is part of the effort to rewrite interactive rebase in C.
>
> The first commit is dedicated to creating a function to silence a
> command, as the sequencer will do in several places with these patches.
>
> This branch is based on ag/rebase-i-rewrite-todo, and does not conflict
> with pu (as of 2018-06-29).

Let's aggregate these topics into a single topic, and perhaps call
it ag/rebase-i-in-c or something like that.  Pretending as if they
are separately replaceable does not make much sense, as you are not
rerolling the earlier one and keep going forward with producing more
parts that depends on the parts that have been submitted earlier.

These three patches looked more-or-less good; I may have spotted a
few nits and suggested improvements, though.

Thanks.