Re: [PATCH] submodule: prevent backslash expantion in submodule names

From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Brandon Williams <bmwill@google.com>,
	git@vger.kernel.org, sbeller@google.com, jo@durchholz.org
Subject: Re: [PATCH] submodule: prevent backslash expantion in submodule names
Date: Sun, 16 Apr 2017 20:09:14 -0700	[thread overview]
Message-ID: <xmqqr30rk9wl.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170408105901.2osi2zadboqxhf34@sigill.intra.peff.net> (Jeff King's message of "Sat, 8 Apr 2017 06:59:01 -0400")

Jeff King <peff@peff.net> writes:

> The reason I mentioned escaping earlier is I wondered what would happen
> when the submodule starts with a double-quote, or has a newline in the
> name. Git's normal quoting would include backslash escape sequences, and
> I wondered if we might be relying on any of these "read" calls to
> interpret them. But I don't think so, for two reasons.
>
> One, because that quoting also puts double-quotes around the name. So
> plain "read" would not be sufficient to de-quote for us anyway.

Correct. These are c-quoting and "read" does not know what to do
with them.

> And two, because these are being fed from "submodule--helper", which
> does not seem to quote in the first place.

Which probably is a bug we can fix safely, as submodule--helper is
merely an implementation detail of our toolset, not something the
end users' scripts can rely on.