All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: larsxschneider@gmail.com
Cc: git@vger.kernel.org, peff@peff.net, jehan@orb.com
Subject: Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override
Date: Sun, 24 Jan 2016 17:25:57 -0800	[thread overview]
Message-ID: <xmqqr3h6bgbe.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1453638170-52041-1-git-send-email-larsxschneider@gmail.com> (larsxschneider@gmail.com's message of "Sun, 24 Jan 2016 13:22:50 +0100")

larsxschneider@gmail.com writes:

> From: Lars Schneider <larsxschneider@gmail.com>
>
> A clean/smudge filter can be disabled if set to an empty string. However,
> Git will try to run the empty string as command which results in a error
> message per processed file.

The above two sentences do not make any sense to me.  You observe
that the command refuses to work when the variable is set to an
empty string--why then can you claim "filter can be disabled if set
to an empty string"?  I'd consider that the system is not working
with such a configuration, i.e. "filter cannot be disabled by
setting it to empty; such a request will result in an error".

> Teach Git to consider an empty clean/smudge filter as legitimately disabled
> and do not print an error message.

On the other hand, this does make sense to me, as I do not think of
a good way to say "earlier configuration entry said we should use
this filter, but we actually do not want to use that one (or any)"
because a configuration, unlike attributes entry, cannot be reset.
The closest you can do is to set it to empty, so it may be a good
new feature to do this.

  parent reply	other threads:[~2016-01-25  1:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-24 12:22 [PATCH] convert: legitimately disable clean/smudge filter with an empty override larsxschneider
2016-01-24 15:06 ` Torsten Bögershausen
2016-01-24 21:35   ` Eric Sunshine
2016-01-27  9:49     ` Lars Schneider
2016-01-27  9:42   ` Lars Schneider
2016-01-24 21:45 ` Jeff King
2016-01-27  9:50   ` Lars Schneider
2016-01-25  1:25 ` Junio C Hamano [this message]
2016-01-28  9:27   ` Lars Schneider
2016-01-28 22:06     ` Junio C Hamano
2016-01-28 23:51 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr3h6bgbe.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jehan@orb.com \
    --cc=larsxschneider@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.