All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t5551: fix the 50,000 tag test
Date: Mon, 09 Jun 2014 12:16:13 -0700	[thread overview]
Message-ID: <xmqqr42xevwi.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5390E2D5.9070000@web.de> ("Torsten =?utf-8?Q?B=C3=B6gershaus?= =?utf-8?Q?en=22's?= message of "Thu, 05 Jun 2014 23:36:21 +0200")

Torsten Bögershausen <tboegi@web.de> writes:

> The first version of test 23 did simply check that no output was send
> to stderr.
>
> Commit 5e2c7cd2 verified that the expected tags were actually cloned.
>
> Since the day "git clone" printed "Cloning into 'too-many-refs'" to stderr,

Thanks.  It is 68b939b2 (clone: send diagnostic messages to stderr,
2013-09-18); before it we showed the message to the standard output
stream instead.

Will queue.

> the test failed because stderr was not empty.
>
> Remove the check for stderr and make t5551-23 pass again
>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
>  t/t5551-http-fetch-smart.sh | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
> index e07eaf3..2c49133 100755
> --- a/t/t5551-http-fetch-smart.sh
> +++ b/t/t5551-http-fetch-smart.sh
> @@ -240,8 +240,7 @@ test_expect_success EXPENSIVE 'create 50,000 tags in the repo' '
>  '
>  
>  test_expect_success EXPENSIVE 'clone the 50,000 tag repo to check OS command line overflow' '
> -	git clone $HTTPD_URL/smart/repo.git too-many-refs 2>err &&
> -	test_line_count = 0 err &&
> +	git clone $HTTPD_URL/smart/repo.git too-many-refs &&
>  	(
>  		cd too-many-refs &&
>  		test $(git for-each-ref refs/tags | wc -l) = 50000

  reply	other threads:[~2014-06-09 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 21:36 [PATCH] t5551: fix the 50,000 tag test Torsten Bögershausen
2014-06-09 19:16 ` Junio C Hamano [this message]
2014-06-10  3:45   ` Torsten Bögershausen
2014-06-10  5:53     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr42xevwi.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.