All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Hu Jialun <hujialun@comp.nus.edu.sg>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 2/2] commit: remove irrelavent prompt on `--allow-empty-message`
Date: Thu, 22 Jul 2021 14:18:51 -0700	[thread overview]
Message-ID: <xmqqsg0682tg.fsf@gitster.g> (raw)
In-Reply-To: <20210722183332.814139-1-hujialun@comp.nus.edu.sg> (Hu Jialun's message of "Fri, 23 Jul 2021 02:33:32 +0800")

Hu Jialun <hujialun@comp.nus.edu.sg> writes:

> Sorry for bothering again; just checking if anything went wrong with
> my previous email about ternary operator conventions :')
>
> https://lore.kernel.org/git/20210710172655.2731007-1-hujialun@comp.nus.edu.sg/

I do not think anything went wrong.

You counted between wrapping after ?: vs before ?: and showed that
locally line-wrapping just before ?:, so that ?  and : appears after
the indent, happens more often, no?

It was my understanding, after your finding above, that we have been
waiting for an updated patch to mimic the majority.

Thanks.

      reply	other threads:[~2021-07-22 21:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06  2:24 [PATCH] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-06 15:44 ` Junio C Hamano
2021-07-07  4:37   ` Felipe Contreras
2021-07-07 10:43   ` Hu Jialun
2021-07-07 16:23 ` Hu Jialun
2021-07-07 16:23   ` [PATCH v2 1/2] commit: reorganise duplicate commit prompt strings Hu Jialun
2021-07-07 16:57     ` Đoàn Trần Công Danh
2021-07-07 17:44       ` Junio C Hamano
2021-07-07 16:23   ` [PATCH v2 2/2] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-07 17:42     ` Felipe Contreras
2021-07-08 15:19   ` [PATCH] " Hu Jialun
2021-07-08 16:05     ` Đoàn Trần Công Danh
2021-07-08 18:26       ` Junio C Hamano
2021-07-09 18:07   ` [PATCH v3 1/2] commit: reorganise commit hint strings Hu Jialun
2021-07-09 19:14     ` Junio C Hamano
2021-07-09 18:07   ` [PATCH v3 2/2] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-09 19:14     ` Junio C Hamano
2021-07-10 17:26       ` Hu Jialun
2021-07-22 18:33       ` Hu Jialun
2021-07-22 21:18         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsg0682tg.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hujialun@comp.nus.edu.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.